Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore #133

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Conversation

eparis
Copy link
Member

@eparis eparis commented Aug 15, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 15, 2018
.gitignore Outdated
.cache

# Created by https://www.gitignore.io/api/go,vim,bazel,emacs,terraform
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather drop the editors here. From gitignore(5):

Patterns which a user wants Git to ignore in all situations (e.g., backup or temporary files generated by the user’s editor of choice) generally go into a file specified by core.excludesFile in the user’s ~/.gitconfig. Its default value is $XDG_CONFIG_HOME/git/ignore. If $XDG_CONFIG_HOME is either not set or empty, $HOME/.config/git/ignore is used instead.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2018
@wking
Copy link
Member

wking commented Aug 15, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2018
@wking
Copy link
Member

wking commented Aug 15, 2018

The e2e-aws error was:

Waiting for router to be created ...
NAME                           STATUS    ROLES     AGE       VERSION
ip-10-0-12-168.ec2.internal    Ready     master    4m        v1.11.0+d4cacc0
ip-10-0-128-104.ec2.internal   Ready     etcd      4m        v1.11.0+d4cacc0
ip-10-0-153-167.ec2.internal   Ready     etcd      4m        v1.11.0+d4cacc0
ip-10-0-173-15.ec2.internal    Ready     etcd      4m        v1.11.0+d4cacc0
NAME      DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
router    1         1         1            0           13s
error: timed out waiting for the condition

/retest

@wking
Copy link
Member

wking commented Aug 15, 2018

The e2e-aws error was:

2018/08/15 16:26:30 Building bin
2018/08/15 16:26:31 Build bin already succeeded in 23s
2018/08/15 16:26:31 Building installer
2018/08/15 16:26:31 Build installer already succeeded in 1m26s
2018/08/15 16:26:31 Tagging installer into stable
2018/08/15 16:26:31 All images ready
2018/08/15 16:26:31 Executing template e2e-aws
2018/08/15 16:26:31 Creating or restarting template instance
2018/08/15 16:26:31 Waiting for template instance e2e-aws to be deleted ...
2018/08/15 16:26:33 Ran for 2s
error: could not run steps: could not create or restart template instance: unable to create template instance: templateinstances.template.openshift.io "e2e-aws" is forbidden: unable to create new content in namespace ci-op-mbjpnc51 because it is being terminated

Maybe a name collision with another parallel e2e-aws run?

/retest

@wking
Copy link
Member

wking commented Aug 15, 2018

From the check table:

tide Pending — Not mergeable. Job ci/prow/golint has not succeeded.

That's probably from openshift/release#1177 landing since the previous /restest. Trigger it manually:

/test golint

@openshift-merge-robot openshift-merge-robot merged commit 4015335 into openshift:master Aug 15, 2018
@eparis eparis deleted the gitignore branch August 29, 2018 20:59
clnperez added a commit to clnperez/installer that referenced this pull request Mar 24, 2022
Merge 'openshift/master' into 'openshift-powervs/add-ipi'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants