Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Document changes since 0.11.0 #1191

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

wking
Copy link
Member

@wking wking commented Feb 5, 2019

Through da6d45b (#890).

Background for the networking.type validation entry is in this thread.

There's still a FIXME for documenting #1185, which I don't understand.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 5, 2019
@wking wking force-pushed the version-0.12.0 branch 5 times, most recently from 4894274 to e67f775 Compare February 5, 2019 00:17
@wking
Copy link
Member Author

wking commented Feb 5, 2019

@abhinavdahiya, thoughts on landing openshift/release#2772 before we cut 0.12.0, so we can drop our nominal v1beta1 support here (and avoid acting like it's supported even though we've dropped two properties)?

@wking
Copy link
Member Author

wking commented Feb 5, 2019

Updated with 9330f0a -> 3c581f5 to document #1185.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2019
@wking
Copy link
Member Author

wking commented Feb 5, 2019

Hmm, do we want to pick up #1182? Just into the merge queue, an it will make it easier to test upgrades.

@wking
Copy link
Member Author

wking commented Feb 5, 2019

I've pushed 2e5acd0 -> 6a97a58 to bump the day to today, since this didn't go out yesterday. We can't actually advance beyond da6d45b (#890) without backports, because the next master commit is d1e59b3 (#1149), and that's incompatible with the pinned update payload.

@wking wking closed this Feb 5, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2019
@wking wking reopened this Feb 5, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2019
CHANGELOG.md Outdated Show resolved Hide resolved
Through da6d45b (Merge pull request openshift#890 from
staebler/asset_loading_tests, 2019-02-04).

Background for the networking.type validation entry is in this thread
[1].

The OpenStack HAProxy entry has wording based on [2] and Russell's
out-of-band suggestions.

Forwarding static-pod longs to systemd is still in flight with [3].

[1]: openshift#1013 (comment)
[2]: https://github.com/openshift/installer/pull/1185/files#r253714521
[3]: openshift/cluster-bootstrap#11
Copy link
Contributor

@crawford crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

@wking
Copy link
Member Author

wking commented Feb 6, 2019

e2e-aws:

level=error msg="\t* aws_vpc.new_vpc: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached."

But now we're back down to 86 VPCs (vs. our cap at 100), so...

/retest

@crawford
Copy link
Contributor

crawford commented Feb 6, 2019

aws_iam_role.bootstrap: Error creating IAM Role ci-op-vhs20b34-1d3f3-bootstrap-role: EntityAlreadyExists: Role with name ci-op-vhs20b34-1d3f3-bootstrap-role already exists.

Pretty sure this won't work...
/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member Author

wking commented Feb 6, 2019

e2e-aws:

level=error msg="\t* module.bootstrap.aws_iam_role.bootstrap: 1 error occurred:"
level=error msg="\t* aws_iam_role.bootstrap: Error creating IAM Role ci-op-z866h59b-1d3f3-bootstrap-role: EntityAlreadyExists: Role with name ci-op-z866h59b-1d3f3-bootstrap-role already exists."
level=error msg="\tstatus code: 409, request id: f4f923c1-2a27-11e9-9f0e-8f9d99bb602e"

But with #1199 out for a while I've made some progress on the orphan backlog, so we should be clear here now. On the other hand, we're not so far in the clear that I think we should be dropping /retests on all our /lgtmed PRs. I'll kick them one at a time as things land.

/retest

@wking
Copy link
Member Author

wking commented Feb 6, 2019

e2e-aws:

level=error msg="2 errors occurred:"
level=error msg="\t* module.bootstrap.aws_s3_bucket.ignition: 1 error occurred:"
level=error msg="\t* aws_s3_bucket.ignition: Error creating S3 bucket: TooManyBuckets: You have attempted to create more buckets than allowed"

But we're down to 127 (of 150?) buckets now, so...

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 6, 2019

@wking: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 2e5acd0 link /test e2e-openstack
ci/prow/e2e-libvirt 2e5acd0 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented Feb 6, 2019

e2e-aws:

level=error msg="4 errors occurred:"
level=error msg="\t* module.vpc.aws_route_table_association.route_net[0]: 1 error occurred:"
level=error msg="\t* aws_route_table_association.route_net.0: timeout while waiting for state to become 'success' (timeout: 5m0s)"

So now we're just hitting rate limits :p. I'll just wait and kick this again tonight.

@wking
Copy link
Member Author

wking commented Feb 7, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 1ea94b1 into openshift:master Feb 7, 2019
@wking wking deleted the version-0.12.0 branch February 7, 2019 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants