-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG: Document changes since 0.11.0 #1191
Conversation
4894274
to
e67f775
Compare
@abhinavdahiya, thoughts on landing openshift/release#2772 before we cut 0.12.0, so we can drop our nominal v1beta1 support here (and avoid acting like it's supported even though we've dropped two properties)? |
Updated with 9330f0a -> 3c581f5 to document #1185. /hold cancel |
Hmm, do we want to pick up #1182? Just into the merge queue, an it will make it easier to test upgrades. |
Through da6d45b (Merge pull request openshift#890 from staebler/asset_loading_tests, 2019-02-04). Background for the networking.type validation entry is in this thread [1]. The OpenStack HAProxy entry has wording based on [2] and Russell's out-of-band suggestions. Forwarding static-pod longs to systemd is still in flight with [3]. [1]: openshift#1013 (comment) [2]: https://github.com/openshift/installer/pull/1185/files#r253714521 [3]: openshift/cluster-bootstrap#11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
But now we're back down to 86 VPCs (vs. our cap at 100), so... /retest |
Pretty sure this won't work... |
/retest Please review the full test history for this PR and help us cut down flakes. |
But with #1199 out for a while I've made some progress on the orphan backlog, so we should be clear here now. On the other hand, we're not so far in the clear that I think we should be dropping /retest |
But we're down to 127 (of 150?) buckets now, so... /retest |
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
So now we're just hitting rate limits :p. I'll just wait and kick this again tonight. |
/retest |
Through da6d45b (#890).
Background for the
networking.type
validation entry is in this thread.There's still a FIXME for documenting #1185, which I don't understand.
/hold