Skip to content

Commit

Permalink
hack: Drop /tmp mounts
Browse files Browse the repository at this point in the history
Eric points out potential issues with relabeling /tmp [1], which is
shared by several system-level consumers.

For the Bazel script, the /tmp mount is just since c483f59 (Move
bazel build tarball test to prow, 2018-08-08, #117), so we can drop it
to return to our previous approach.

The Terraform container seems to run fine without /tmp as well,
although there's no clear history to point to on this front because we
used to use Bazel for this.  See b8a9bbc (Remove bazel from test
process, 2018-08-01, #97).

[1]: #174 (comment)
  • Loading branch information
wking committed Aug 28, 2018
1 parent 0133912 commit 4ba649b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion hack/test-bazel-build-tarball.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ else
docker run --rm \
--env IS_CONTAINER=TRUE \
--volume "${PWD}:${PWD}:z" \
--volume /tmp:/tmp:z \
--workdir "${PWD}" \
quay.io/coreos/tectonic-builder:bazel-v0.3 \
./hack/test-bazel-build-tarball.sh
Expand Down
1 change: 0 additions & 1 deletion hack/tf-fmt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ else
docker run --rm \
--env IS_CONTAINER=TRUE \
--volume "${PWD}:${PWD}:ro,z" \
--volume /tmp:/tmp:z \
--workdir "${PWD}" \
quay.io/coreos/terraform-alpine:v0.11.7 \
./hack/tf-fmt.sh
Expand Down

0 comments on commit 4ba649b

Please sign in to comment.