Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource requests to ROKS metrics pods #86

Merged

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Oct 21, 2020

The resources needed by these pods are very small. In practice, I haven't seen them go over 0.5m for cpu and 30Mi for memory. Not sure that it's worth parameterizing.
Fixes #85

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@csrwng
Copy link
Contributor Author

csrwng commented Oct 21, 2020

@rtheis ptal

Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

@rtheis: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rtheis
Copy link
Contributor

rtheis commented Oct 22, 2020

Here's the CPU and memory usage from a ROKS 4.5 cluster just deployed. We may be able to lower these depending on long term resource utilization. But for now, the PR seems reasonable.

$ kubectl top pods -n openshift-roks-metrics
NAME                      CPU(cores)   MEMORY(bytes)   
metrics-d75db69d9-8xf5q   0m           23Mi  

@csrwng csrwng added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit b265cc9 into openshift:master Oct 22, 2020
@csrwng
Copy link
Contributor Author

csrwng commented Oct 22, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot

@csrwng: new pull request created: #87

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROKS metrics component is missing CPU and memory requests
5 participants