-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource requests to ROKS metrics pods #86
Add resource requests to ROKS metrics pods #86
Conversation
@rtheis ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@rtheis: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, rtheis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Here's the CPU and memory usage from a ROKS 4.5 cluster just deployed. We may be able to lower these depending on long term resource utilization. But for now, the PR seems reasonable.
|
/cherry-pick release-4.5 |
@csrwng: new pull request created: #87 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The resources needed by these pods are very small. In practice, I haven't seen them go over 0.5m for cpu and 30Mi for memory. Not sure that it's worth parameterizing.
Fixes #85