Bump capa and golang #703
Merged
Bump capa and golang #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
enxebre
force-pushed
the
bump-capa-and-golang
branch
from
2efaeec to
590d1e6
Compare
|
✔️ Deploy Preview for hypershift-docs ready! 🔨 Explore the source changes: e885746 🔍 Inspect the deploy log: https://app.netlify.com/sites/hypershift-docs/deploys/619cd95f3f10da00089b0efc 😎 Browse the preview: https://deploy-preview-703--hypershift-docs.netlify.app/quickstart |
enxebre
force-pushed
the
bump-capa-and-golang
branch
from
590d1e6 to
f2511cb
Compare
openshift-ci
bot
added
the
needs-rebase
enxebre
force-pushed
the
bump-capa-and-golang
branch
from
f2511cb to
e885746
Compare
openshift-ci
bot
removed
the
needs-rebase
Bring CAPA v1beta1, kube 1.23 deps and golang 1.17. Drops https://github.com/bombsimon/logrusr/ which does not support golang 1.17 in favour of zapr. Adds .ci-operator.yaml so upcoming golang bumps can be done in this repo atomically. Note the TODO in HostedCluster This kubernetes-sigs/cluster-api-provider-aws#2728 broke our assumption in CAPA 0.7 for externally managed infrastructure. This effectively limit our ability to span NodePools across multiple subnets. In a follow up we need to either enable upstream back to support arbitrary subnets IDs in the awsMachine CR or possibly expose a slice of available subnets for NodePools in hcluster.Spec.Platform.AWS.
enxebre
force-pushed
the
bump-capa-and-golang
branch
from
e885746 to
0c77b1a
Compare
alvaroaleman
approved these changes
Nov 23, 2021
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
enxebre
added a commit
to enxebre/release
that referenced
this pull request
Nov 23, 2021
This along with openshift/hypershift#703 and openshift#23848 let us bump golang versions by making changes to the source repo only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring CAPA v1beta1, kube 1.23 deps and golang 1.17.
Drops https://github.com/bombsimon/logrusr/ which does not support golang 1.17 in favour of zapr.
Adds .ci-operator.yaml so upcoming golang bumps can be done in this repo atomically.
Note the TODO in HostedCluster
This kubernetes-sigs/cluster-api-provider-aws#2728 broke our assumption in CAPA 0.7 for externally managed infrastructure. This effectively limit our ability to span NodePools across multiple subnets. In a follow up we need to either enable upstream back to support arbitrary subnets IDs in the awsMachine CR or possibly expose a slice of available subnets for NodePools in hcluster.Spec.Platform.AWS.
Needs openshift/release#23848