Support hypershift-operator scoping for secretJanitor

[pamelachristie]

What this PR does / why we need it:

These changes extend the hostedcluster annotation scoping support to the secretJanitor. The secretJanitor was originally introduced in #3969, but scoping support was not included. Scoping support was originally introduced in #3702.

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	ace0345
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/671a9d6af785060009d32f2f
😎 Deploy Preview	https://deploy-preview-4979--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pamelachristie
Once this PR has been reviewed and has the lgtm label, please assign csrwng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @pamelachristie. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[enxebre]

Thanks! are you ok to cover the filter func within PredicatesForHostedClusterAnnotationScoping and also getHostedClusterScopeAnnotation with unit tests before extending their consumption any further?

[pamelachristie]

@enxebre are you looking for me to provide more unit testing for the already implemented functions?

[pamelachristie]

@enxebre bump

[bryan-cox]

/ok-to-test

[pamelachristie]

/retest-required

[pamelachristie]

/retest-required

[pamelachristie]

@bryan-cox @enxebre could I get some help determining why some of the PR tests are failing?

[bryan-cox]

/retest-required

[bryan-cox]

AKS test seems like a flake.

The override test I believe is known to be broken.

[openshift-ci]

@pamelachristie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	ace0345	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-override	ace0345	link	true	/test e2e-aws-override

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.