Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update capi/capa images #472

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Sep 14, 2021

To pick kubernetes-sigs/cluster-api#5110 in capi and use capa 0.7.0 release image.
Will drop this when plumbing these images through our pipeline.

Fixes #471

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from csrwng and sjenning September 14, 2021 22:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2021
@enxebre
Copy link
Member Author

enxebre commented Sep 14, 2021

/test e2e-aws-pooled
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2021
@enxebre
Copy link
Member Author

enxebre commented Sep 15, 2021

/test e2e-aws-pooled

@csrwng
Copy link
Contributor

csrwng commented Sep 15, 2021

@enxebre I tried this manually and the capa controller is crashing:

E0915 20:16:50.077326       1 internal.go:528] controller-runtime/manager "msg"="error received after stop sequence was engaged" "error"="leader election lost"
E0915 20:16:50.077327       1 deleg.go:144] setup "msg"="problem running manager" "error"="failed to wait for awsmanagedcontrolplane caches to sync: no matches for kind \"AWSManagedControlPlane\" in version \"controlplane.cluster.x-k8s.io/v1alpha4\""

@csrwng
Copy link
Contributor

csrwng commented Sep 15, 2021

@enxebre turning the eks feature flag off fixed it for me
enxebre#1

To pick kubernetes-sigs/cluster-api#5110 in capi and use capa 0.7.0 release image.
Will drop this when plumbing these images through our pipeline.
@enxebre
Copy link
Member Author

enxebre commented Sep 17, 2021

/test e2e-aws-pooled

2 similar comments
@enxebre
Copy link
Member Author

enxebre commented Sep 17, 2021

/test e2e-aws-pooled

@csrwng
Copy link
Contributor

csrwng commented Sep 17, 2021

/test e2e-aws-pooled

@enxebre
Copy link
Member Author

enxebre commented Sep 20, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021
@ironcladlou
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2021
@openshift-merge-robot openshift-merge-robot merged commit ca454c9 into openshift:main Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

machine health checks causing capi controller to panic
4 participants