Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-34699: Allow access to root-ca configmap in cluster-network-operator role #4122

Merged
merged 2 commits into from
Jun 4, 2024
Merged

OCPBUGS-34699: Allow access to root-ca configmap in cluster-network-operator role #4122

merged 2 commits into from
Jun 4, 2024

Conversation

riendeau
Copy link
Contributor

What this PR does / why we need it:

Adds root-ca to the resourceNames in the cluster-network-operator role to provide the access required.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:

https://issues.redhat.com/browse/OCPBUGS-34699

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 30, 2024
@openshift-ci-robot
Copy link

@riendeau: This pull request references Jira Issue OCPBUGS-34699, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

Adds root-ca to the resourceNames in the cluster-network-operator role to provide the access required.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:

https://issues.redhat.com/browse/OCPBUGS-34699

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 30, 2024
@openshift-ci openshift-ci bot requested review from hasueki and sjenning May 30, 2024 20:41
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed do-not-merge/needs-area labels May 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2024

Hi @riendeau. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rtheis
Copy link
Contributor

rtheis commented May 30, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 30, 2024
@rtheis
Copy link
Contributor

rtheis commented May 30, 2024

/jira refresh

@openshift-ci-robot
Copy link

@rtheis: This pull request references Jira Issue OCPBUGS-34699, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hasueki
Copy link
Contributor

hasueki commented May 30, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 30, 2024
@openshift-ci-robot
Copy link

@hasueki: This pull request references Jira Issue OCPBUGS-34699, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 30, 2024
hasueki
hasueki approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@hasueki hasueki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
rtheis
rtheis suggested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update unit tests for this change.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
rtheis
rtheis approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
@riendeau
Copy link
Contributor Author

/retest-required

@rtheis
Copy link
Contributor

rtheis commented May 31, 2024

/retest-required

4 similar comments
@riendeau
Copy link
Contributor Author

/retest-required

@rtheis
Copy link
Contributor

rtheis commented May 31, 2024

/retest-required

@riendeau
Copy link
Contributor Author

/retest-required

@riendeau
Copy link
Contributor Author

riendeau commented Jun 1, 2024

/retest-required

@riendeau
Copy link
Contributor Author

riendeau commented Jun 2, 2024

/assign davidvossel

@csrwng
Copy link
Contributor

csrwng commented Jun 4, 2024

/approve

@csrwng
Copy link
Contributor

csrwng commented Jun 4, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, hasueki, riendeau, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, hasueki, riendeau, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e66add8 and 2 for PR HEAD b26b1c6 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024 •
edited
Loading

@riendeau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure b26b1c6 link false /test e2e-azure
ci/prow/e2e-kubevirt-azure-ovn b26b1c6 link false /test e2e-kubevirt-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@riendeau
Copy link
Contributor Author

riendeau commented Jun 4, 2024

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit be9e3f8 into openshift:main Jun 4, 2024
12 of 14 checks passed
@openshift-ci-robot
Copy link

@riendeau: Jira Issue OCPBUGS-34699: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34699 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:

Adds root-ca to the resourceNames in the cluster-network-operator role to provide the access required.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:

https://issues.redhat.com/browse/OCPBUGS-34699

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rtheis
Copy link
Contributor

rtheis commented Jun 4, 2024

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link

@rtheis: new pull request created: #4155

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 4, 2024
Merged
@riendeau riendeau deleted the add-root-ca-rbac branch June 4, 2024 21:48
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.17.0-202406050012.p0.gbe9e3f8.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasueki hasueki hasueki approved these changes

@rtheis rtheis rtheis approved these changes

@csrwng csrwng csrwng approved these changes

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@davidvossel davidvossel

@csrwng csrwng

@rtheis rtheis

@hasueki hasueki

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@riendeau @openshift-ci-robot @rtheis @hasueki @csrwng @openshift-cherrypick-robot @openshift-bot @davidvossel