OCPBUGS-33724: Fixes update issue with KubeVirt platform

[davidvossel]

A bug fix (#3382) went in earlier this year that corrected an issue where the kubevirt cloud controller manager (kccm) was not having the deployment config accurately applied.

This resulted in some deployments having the replace update strategy instead of RollingUpdate update strategy.

When we update OCP from one of the older versions which deployed kccm with replace strategy, the update fails because we attempt to set RollingUpdate update strategy parameters when the update strategy is still replace.

To fix this, when we set the inplace update parameters, we need to ensure that the upstate strategy type is set to RollingUpdate as well.

[openshift-ci-robot]

@davidvossel: This pull request references Jira Issue OCPBUGS-33724, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

A bug fix (#3382) went in earlier this year that corrected an issue where the kubevirt cloud controller manager (kccm) was not having the deployment config accurately applied.

This resulted in some deployments having the replace update strategy instead of RollingUpdate update strategy.

When we update OCP from one of the older versions which deployed kccm with replace strategy, the update fails because we attempt to set RollingUpdate update strategy parameters when the update strategy is still replace.

To fix this, when we set the inplace update parameters, we need to ensure that the upstate strategy type is set to RollingUpdate as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [davidvossel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davidvossel]

/jira refresh

[openshift-ci-robot]

@davidvossel: This pull request references Jira Issue OCPBUGS-33724, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[davidvossel]

/area control-plane-operator

[davidvossel]

/retest

[jparrill]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d5b642b and 2 for PR HEAD 78ed89e in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 6ccf12b and 1 for PR HEAD 78ed89e in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 99ca57b and 0 for PR HEAD 78ed89e in total

[openshift-ci-robot]

/hold

Revision 78ed89e was retested 3 times: holding

[davidvossel]

/hold cancel

[davidvossel]

/retest required

[openshift-ci]

@davidvossel: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

• /test e2e-aws
• /test e2e-kubevirt-aws-ovn
• /test images
• /test unit
• /test verify

The following commands are available to trigger optional jobs:

• /test e2e-aws-metrics
• /test e2e-azure
• /test e2e-conformance
• /test e2e-ibmcloud-iks
• /test e2e-ibmcloud-roks
• /test e2e-kubevirt-azure-ovn
• /test e2e-kubevirt-metal-conformance
• /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-openshift-hypershift-main-e2e-aws
• pull-ci-openshift-hypershift-main-e2e-azure
• pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
• pull-ci-openshift-hypershift-main-e2e-kubevirt-azure-ovn
• pull-ci-openshift-hypershift-main-images
• pull-ci-openshift-hypershift-main-unit
• pull-ci-openshift-hypershift-main-verify

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[davidvossel]

/test e2e-azure e2e-aws

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c0c55a0 and 2 for PR HEAD 78ed89e in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1c48678 and 1 for PR HEAD 78ed89e in total

[openshift-ci]

@davidvossel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure	78ed89e	link	false	/test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@davidvossel: Jira Issue OCPBUGS-33724: All pull requests linked via external trackers have merged:

• openshift/hypershift#4039

Jira Issue OCPBUGS-33724 has been moved to the MODIFIED state.

In response to this:

A bug fix (#3382) went in earlier this year that corrected an issue where the kubevirt cloud controller manager (kccm) was not having the deployment config accurately applied.

This resulted in some deployments having the replace update strategy instead of RollingUpdate update strategy.

When we update OCP from one of the older versions which deployed kccm with replace strategy, the update fails because we attempt to set RollingUpdate update strategy parameters when the update strategy is still replace.

To fix this, when we set the inplace update parameters, we need to ensure that the upstate strategy type is set to RollingUpdate as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.17.0-202406041111.p0.gcd2d529.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

[davidvossel]

/cherry-pick release-4.16 release-4.15 release-4.14

[openshift-cherrypick-robot]

@davidvossel: new pull request created: #4817

In response to this:

/cherry-pick release-4.16 release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.