OCPBUGS-32186: cmd: report server version, supported OCP #3987
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@stevekuznetsov: This pull request references Jira Issue OCPBUGS-32186, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
do-not-merge/needs-area
area/cli
stevekuznetsov
force-pushed
the
skuznets/cli-report-supported-versions
branch
2 times, most recently
from
749c8fe to
9c0bfcc
Compare
stevekuznetsov
force-pushed
the
skuznets/cli-report-supported-versions
branch
from
9c0bfcc to
bdbebb5
Compare
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
/retest |
|
/jira-refresh |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@stevekuznetsov: This pull request references Jira Issue OCPBUGS-32186, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/retest |
|
/cherrypick release-4.15 release-4.14 |
|
@stevekuznetsov: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
1 similar comment
|
/retest |
Previously, both hcp and hypershift CLIs would only report their client versions, which was misleading to some users, as the real determination for what versions of OCP are possible to deploy relies on both the client and the server together. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/cli-report-supported-versions
branch
from
bdbebb5 to
c624e1e
Compare
| @@ -61,7 +65,8 @@ func LookupDefaultOCPVersion(releaseStream string) (OCPVersion, error) { | |||
| } | |||
|
|
|||
| func NewVersionCommand() *cobra.Command { | |||
| var commitOnly bool | |||
| var commitOnly, clientOnly bool | |||
| namespace := "hypershift" | |||
There was a problem hiding this comment.
This assumption might not always be true
There was a problem hiding this comment.
It's hard-coded into the rest of the repo right now, so not sure how to improve it?
| @@ -22,8 +23,9 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| configMapKey = "supported-versions" | |||
| supportedVersionsLabel = "hypershift.openshift.io/supported-versions" | |||
| ConfigMapVersionsKey = "supported-versions" | |||
There was a problem hiding this comment.
This is resulting confusing at least for me, it'd be nice to include in the naming if we are referring to HOVersion or OCPVersions
|
Dropped some minors, feel free to follow up on them |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/hold Revision c624e1e was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest-required |
|
/retest |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@stevekuznetsov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit c0c55a0
into
openshift:main
|
@stevekuznetsov: Jira Issue OCPBUGS-32186: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-32186 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@stevekuznetsov: new pull request created: #4140 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@stevekuznetsov: new pull request created: #4141 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.17.0-202406031613.p0.gc0c55a0.assembly.stream.el9 for distgit hypershift. |
Previously, both hcp and hypershift CLIs would only report their client versions, which was misleading to some users, as the real determination for what versions of OCP are possible to deploy relies on both the client and the server together.
/cc @davidvossel