-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure kubevirt-csi containers all have resource.Requests and PullPolicy set #1816
Ensure kubevirt-csi containers all have resource.Requests and PullPolicy set #1816
Conversation
policy set Signed-off-by: David Vossel <[email protected]>
2cc609e
to
3fb6d26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws |
@davidvossel: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Some of our KubeVirt csi containers didn't have resource requests and pull policy set. This wasn't caught by CI initially when kubevirt-csi was merged due to this openshift/release issue that caused the presubmit not to use the latest CPO/HCCO in the pr. Now that the ci issue is resolved, we have ci failures due to the requests check.
This PR fixes the following issues in our KubeVirt e2e CI.