Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added "Scale dataplane to zero" workflow to the documentation #1804

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

jparrill
Copy link
Contributor

@jparrill jparrill commented Oct 14, 2022

Documented the "Scale data plane to zero" workflow to allow the customers to save money and compute time. It's mainly focussed in AWS but should be provider agnostic.

Signed-off-by: Juan Manuel Parrilla Madrid [email protected]

Which issue(s) this PR fixes
Fixes #HOSTEDCP-576

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from csrwng and enxebre October 14, 2022 14:42
@netlify
Copy link

netlify bot commented Oct 14, 2022

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 5f479f9
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/634d21cf1e6c520008f1bc99
😎 Deploy Preview https://deploy-preview-1804--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

docs/mkdocs.yml Outdated Show resolved Hide resolved
@enxebre
Copy link
Member

enxebre commented Oct 17, 2022

Thanks Juan! Let's please retitle the PR title and desc to remove any reference to hibernation. This is just about illustrating how scaling down and draining works.

Documented the "Scale dataplane to zero" workflow to allow the customers to save money and compute time. It's mainly focussed in AWS but should be provider agnostic.

Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>
@jparrill jparrill changed the title feat: Added hibernate workflow to the documentation feat: Added "Scale dataplane to zero" workflow Oct 17, 2022
@jparrill jparrill changed the title feat: Added "Scale dataplane to zero" workflow feat: Added "Scale dataplane to zero" workflow to the documentation Oct 17, 2022
@jparrill jparrill requested review from enxebre and zanetworker and removed request for csrwng and enxebre October 17, 2022 10:25
@jparrill
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2022
@zanetworker
Copy link

lgtm

@enxebre
Copy link
Member

enxebre commented Oct 17, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2022
@jparrill
Copy link
Contributor Author

I will create another PR for the E2E test in order to deliver the documentation

@jparrill
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

@jparrill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/capi-provider-agent-sanity 5f479f9 link false /test capi-provider-agent-sanity

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1f70f40 into openshift:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants