Kind 0.8.1 devenv #978

dgoodwin · 2020-05-07T18:37:49Z

New script is based off an example in kind.

Been trying to get this to work but it's stuck communicating with the insecure registry, no route to host despite supposedly being on the network. I've exec'd into the kind control plane container and using curl, neither localhost, nor the container name (kind-registry), nor the ip seem to work. It just can't reach that container.

Any advice welcome, going to keep trying to poke at this.

Still haven't tried it with podman.

Fixes: #833

dgoodwin · 2020-05-08T18:49:00Z

Script seems to work once I made two Fedora 32 hacks to fix docker container networking in general:

sudo firewall-cmd --permanent --zone=trusted --add-interface=docker0
change the FirewallBackend in the /etc/firewalld/firewalld.conf file from nftables to iptables and restart docker ([firewalld] kind doesn't work on Fedora 32 kubernetes-sigs/kind#1547 (comment))

So this script replaces both of our current ones for kind and registry into one much smaller and simpler script.

Next step podman.

dgoodwin · 2020-05-08T19:18:19Z

hive-operator appears to be successful, but hotloops and pins the cpu. Investigating.

dgoodwin · 2020-05-11T12:44:56Z

Hotloop fixed, details in commit, some interesting complications may be coming with Kube 1.18+ due to server side apply.

Updated docs.

staebler · 2020-05-11T16:58:55Z

docs/developing.md

-```
-
-Create a kind cluster named 'hive' to deploy to. You can create as many kind clusters as you need.:
+Create a local insecure registry (if one does not already exist) and then a kind cluster named 'hive' to deploy to. You can create as many kind clusters as you need and you have sufficient RAM.

 ```bash
 ./hack/create-kind-cluster.sh hive


Add a note after this that the following error is expected the first time this is run and is not indicative of an error.

Error response from daemon: container fcca36a26da5601d6453c0c53ab5909eb6ca8ffe42de0f8634dd7213f107cef0 is not connected to network kind

staebler · 2020-05-11T17:00:12Z

hack/create-kind-cluster.sh

-"
-EOF
-fi
+# tell https://tilt.dev to use the registry


Is this section required? If so, we should remove the references to tilt.

Didn't even realize, no it does not seem necessary, removing.

staebler · 2020-05-11T17:06:59Z

docs/developing.md

-```
-
-Create a kind cluster named 'hive' to deploy to. You can create as many kind clusters as you need.:
+Create a local insecure registry (if one does not already exist) and then a kind cluster named 'hive' to deploy to. You can create as many kind clusters as you need and you have sufficient RAM.


The part about sufficient RAM could use some grammatical work. I do not think that it is necessary to call out specifically RAM.

Suggested change

Create a local insecure registry (if one does not already exist) and then a kind cluster named 'hive' to deploy to. You can create as many kind clusters as you need and you have sufficient RAM.

Create a local insecure registry (if one does not already exist) and then a kind cluster named 'hive' to deploy to. You can create multiple kind clusters. Each kind cluster needs a unique name, which is specified by the argument passed to the script.

Switch to a much simpler script for creating a kind cluster to develop hive against, with an integrated registry. The registry is now linked to the container with docker networking and the new script takes place of both of the old ones, if there is no registry container one will be started for you.

1.18 introduces beta of server side apply, which adds field tracking to object metadata for who set the value of a field. On Update, this includes a timestamp. Hive operator was blindly doing updates and thus the timestamp was constantly changing, leading to a hotloop.

dgoodwin · 2020-05-11T17:27:02Z

Updates pushed and WIP removed. Matthew and Joel have confirmed this works for them so I think we're ok to proceed.

Added some additional notes on the Fedora hacks that may be required.

dgoodwin · 2020-05-20T12:03:27Z

Needs approval, should be ready to go.

staebler

Bah, had one very minor comment that I never submitted from a week ago. Otherwise, this looks good to me.

staebler · 2020-05-11T18:09:41Z

docs/developing.md


-Create a kind cluster named 'hive' to deploy to. You can create as many kind clusters as you need.:
+Create a local insecure registry (if one does not already exist) and then a kind cluster named 'hive' to deploy to. You can create additional clusters if desired by provising a different name argument to the script.


s/provising/providing/

suhanime · 2020-05-21T14:22:35Z

docs/developing.md


 ```bash
-export KUBECONFIG="$(kind get kubeconfig-path --name="hive")"


The new kind does not have get kubeconfig-path so also need to change the docs in Adopting clusterdeployments section

Thanks, I replaced it with /path/to/admin/kubeconfig.

dgoodwin · 2020-05-21T18:23:52Z

PR updated, would love to get merged before freeze!

staebler · 2020-05-21T18:38:42Z

docs/developing.md

@@ -130,7 +129,7 @@ To create a kind cluster and adopt:

 ```bash
 ./hack/create-kind-cluster.sh cluster1
-bin/hiveutil create-cluster --base-domain=new-installer.openshift.com kind-cluster1 --adopt --adopt-admin-kubeconfig=$(kind get kubeconfig-path --name="cluster1") --adopt-infra-id=fakeinfra --adopt-cluster-id=fakeid
+bin/hiveutil create-cluster --base-domain=new-installer.openshift.com kind-cluster1 --adopt --adopt-admin-kubeconfig=/path/to/cluster/admin/kubeconfig get kubeconfig-path --name="cluster1") --adopt-infra-id=fakeinfra --adopt-cluster-id=fakeid


Remove the following.

get kubeconfig-path --name="cluster1")

Arghhh sorry, updated again.

staebler

/lgtm

openshift-ci-robot · 2020-05-21T20:28:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dgoodwin,staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-05-22T00:23:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-22T00:49:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-22T01:03:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2020

openshift-ci-robot requested review from abutcher and csrwng May 7, 2020 18:38

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020

dgoodwin force-pushed the kind-0.8.1 branch from b661af3 to c821cfe Compare May 8, 2020 19:03

dgoodwin force-pushed the kind-0.8.1 branch from ab24108 to 982c333 Compare May 11, 2020 16:59

staebler reviewed May 11, 2020

View reviewed changes

dgoodwin force-pushed the kind-0.8.1 branch from 982c333 to 7afff5c Compare May 11, 2020 17:19

dgoodwin changed the title ~~WIP: Kind 0.8.1 devenv~~ Kind 0.8.1 devenv May 11, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2020

dgoodwin added 2 commits May 11, 2020 14:22

dgoodwin force-pushed the kind-0.8.1 branch from 7afff5c to 55f323e Compare May 11, 2020 17:26

staebler reviewed May 21, 2020

View reviewed changes

suhanime reviewed May 21, 2020

View reviewed changes

dgoodwin force-pushed the kind-0.8.1 branch from 55f323e to 09a1db8 Compare May 21, 2020 18:23

staebler reviewed May 21, 2020

View reviewed changes

Docs updates for kind 0.8.1.

7c5494b

dgoodwin force-pushed the kind-0.8.1 branch from 09a1db8 to 7c5494b Compare May 21, 2020 20:19

staebler approved these changes May 21, 2020

View reviewed changes

openshift-ci-robot assigned staebler May 21, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2020

openshift-merge-robot merged commit 39d1b4f into openshift:master May 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kind 0.8.1 devenv #978

Kind 0.8.1 devenv #978

dgoodwin commented May 7, 2020 •

edited by gregsheremeta

Loading

dgoodwin commented May 8, 2020 •

edited

Loading

dgoodwin commented May 8, 2020

dgoodwin commented May 11, 2020

staebler May 11, 2020

staebler May 11, 2020

dgoodwin May 11, 2020

staebler May 11, 2020

dgoodwin commented May 11, 2020

dgoodwin commented May 20, 2020

staebler left a comment

staebler May 11, 2020

suhanime May 21, 2020

dgoodwin May 21, 2020

dgoodwin commented May 21, 2020

staebler May 21, 2020

dgoodwin May 21, 2020

staebler left a comment

openshift-ci-robot commented May 21, 2020

openshift-bot commented May 22, 2020

openshift-bot commented May 22, 2020

openshift-bot commented May 22, 2020

	Create a local insecure registry (if one does not already exist) and then a kind cluster named 'hive' to deploy to. You can create as many kind clusters as you need and you have sufficient RAM.
	Create a local insecure registry (if one does not already exist) and then a kind cluster named 'hive' to deploy to. You can create multiple kind clusters. Each kind cluster needs a unique name, which is specified by the argument passed to the script.


		Create a kind cluster named 'hive' to deploy to. You can create as many kind clusters as you need.:
		Create a local insecure registry (if one does not already exist) and then a kind cluster named 'hive' to deploy to. You can create additional clusters if desired by provising a different name argument to the script.


		```bash
		export KUBECONFIG="$(kind get kubeconfig-path --name="hive")"

Kind 0.8.1 devenv #978

Kind 0.8.1 devenv #978

Conversation

dgoodwin commented May 7, 2020 • edited by gregsheremeta Loading

dgoodwin commented May 8, 2020 • edited Loading

dgoodwin commented May 8, 2020

dgoodwin commented May 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgoodwin commented May 11, 2020

dgoodwin commented May 20, 2020

staebler left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgoodwin commented May 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

staebler left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented May 21, 2020

openshift-bot commented May 22, 2020

openshift-bot commented May 22, 2020

openshift-bot commented May 22, 2020

dgoodwin commented May 7, 2020 •

edited by gregsheremeta

Loading

dgoodwin commented May 8, 2020 •

edited

Loading