Add make verify target #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
twiest
commented
Sep 24, 2018
twiest
commented
- Add make verify target
- Add verify-lint target
- Add verify-gofmt target
- Add verify-go-vet target
- Fix make verify-imports target to error when verify-imports fails.
- Fix golint errors in codebase
- Remove fmt and vet targets from build targets (necessary for make verify to work)
- Add .PHONY to Makefile targets that don't produce files of the same name.
openshift-ci-robot
added
the
size/M
|
/lgtm |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/shrug |
- [x] Add make verify target - [x] Add verify-lint target - [x] Add verify-gofmt target - [x] Add verify-go-vet target - [x] Fix make verify-imports target to error when verify-imports fails. - [x] Fix golint errors in codebase - [x] Remove fmt and vet targets from build targets (necessary for make verify to work) - [x] Add .PHONY to Makefile targets that don't produce files of the same name.
|
@dgoodwin hey, I rebased on master and had to update some of the new code to comply with Would you mind reviewing this again please? |
|
/lgtm |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Sep 29, 2018
I updated the import path to keep up with openshift/hive@ae569e39 (Add make verify target, 2018-09-24, openshift/hive#13). Then I bumped vendor/ with: $ rm -rf ~/.glide/cache/info/https-github.com-openshift-hive.json ~/.glide/cache/src/https-github.com-openshift-hive/ $ glide remove github.com/openshift/hive $ glide get --strip-vendor github.com/openshift/hive $ glide-vc --use-lock-file --no-tests --only-code $ git checkout HEAD -- vendor/github.com/shurcooL/httpfs using: $ glide --version glide version 0.13.2-dev $ (cd $GOPATH/src/github.com/Masterminds/glide && git describe) v0.13.1-7-g3e13fd1 $ (cd $GOPATH/src/github.com/sgotti/glide-vc && git describe) v0.1.0-2-g6ddf6ee I don't know why I needed to clear my cache, but without that line the remaining commands didn't bump vendor/github.com/openshift/hive to its current master. Bumping to openshift/hive@a050d775 (Merge pull request openshift/hive#28 from wking/tag-20-load-balancers-per-request, 2018-09-28) gives us more reliable load-balancer deletion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.