Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest in the CSV instead of a version tag #577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Oct 15, 2024

This makes it so that the replace logic also replaces the deployment
image in addition to the related image. This is necessary CI to work
properly, because it needs to be able to replace all images in the CSV
with a build from CI.

This makes it so that the replace logic also replaces the deployment
image in addition to the related image. This is necessary CI to work
properly, because it needs to be able to replace all images in the CSV
with a build from CI.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2024
@yuumasato
Copy link
Contributor

This seems to work, but there were a lot of test failures, 😢

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Oct 17, 2024

/test e2e-bundle-aws

@yuumasato
Copy link
Contributor

Yes, I think we need this change.

But we also need this change in the FIO release PR too.

@yuumasato
Copy link
Contributor

/retest-required

@yuumasato
Copy link
Contributor

I have cherry-picked this commit to the release PR.

Copy link
Contributor

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuumasato
Copy link
Contributor

/test e2e-aws

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4632e3c and 2 for PR HEAD b562ac3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cd3850d and 2 for PR HEAD b562ac3 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cd3850d and 2 for PR HEAD b562ac3 in total

Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-rosa b562ac3 link false /test e2e-rosa
ci/prow/e2e-aws b562ac3 link true /test e2e-aws
ci/prow/e2e-bundle-aws-upgrade b562ac3 link true /test e2e-bundle-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants