UPSTREAM <carry>: etcdctl: allow move-leader to connect to multiple e… #146
Conversation
|
@tjungblu: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tjungblu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
this is a carry for https://bugzilla.redhat.com/show_bug.cgi?id=1918413 |
|
just tested with cluster-bot, works like a charm: |
|
/test e2e-aws-serial |
Due to a duplicate call of clientConfigFromCmd, the move-leader command would fail with "conflicting environment variable is shadowed by corresponding command-line flag". Also in scenarios where no command-line flag was supplied. This can be removed on a branch rebased to 3.6 safely. Signed-off-by: Thomas Jungblut <[email protected]>
tjungblu
force-pushed
the
bz_1918413_3.5_openshift
branch
from
dddb0ac to
2cfc6dc
Compare
|
/retest |
|
@tjungblu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
superseded by the rebase to 3.5.5 |
…ndpoints
Re-opening closed PR etcd-io#11775 which was originaly authored by benmoss. Then again opened PR etcd-io#12757 which was authored by zerodayz.
The mustClientForCmd function is responsible for parsing environment variables and flags into configuration data. A change was made in etcd-io#9382 to call Fatal if a flag is provided multiple times. This means that we cannot call the mustClientForCmd function more than once, since it will think that flags parsed the first time are now being redefined and error out.
Some people have commented about this in etcd-io#8380 but I don't think there's an open issue for it.
Signed-off-by: Thomas Jungblut [email protected]
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.