Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-2006: Rebase to upstream v1.16.0 for OCP 4.18 #12

Merged
merged 52 commits into from
Oct 8, 2024

Conversation

andyzhangx and others added 30 commits July 18, 2024 07:01
…hart-change

fix: revert v1.14.0 chart change
…unt-issue2

fix: unmount detection failure
…ermission

fix: tmp path mount permission issue
…rmission

fix: add pv patch permission with HonorPVReclaimPolicy enabled
Using the linux.krb5CacheDirectory helm option doesn't work due to an invalid volume name:

spec.volumes[0].name: Invalid value: "krb5Cache-dir": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-',
and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')
…che-volume-name

fix: node kerberos cache volume name
test: add default namespace in examples to fix e2e test failure
…st-failure

test: fix external test failure
…ilure

test: fix windows e2e test failure
…-5.0.2

fix: upgrade csi-provisioner to v5.0.2 to fix pv deletion stuck issue
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2024

@dfajmon: This pull request references STOR-2006 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Issue link:
https://issues.redhat.com/browse/STOR-2006

Diff to upstream v1.14.0:
kubernetes-csi/csi-driver-smb@v1.16.0...dfajmon:rebase-1.16.0

Changes between 1.14.0 (OCP 4.17) and 1.16.0 (OCP 4.18):
1.15.0

1.16.0

Full changelogs:
https://github.com/kubernetes-csi/csi-driver-smb/releases/tag/v1.15.0
https://github.com/kubernetes-csi/csi-driver-smb/releases/tag/v1.16.0

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Sep 3, 2024

@dfajmon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f461041 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane
Copy link

/lgtm
/approve
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Sep 16, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@Phaow
Copy link

Phaow commented Sep 30, 2024

Pre merge test passed with manual build driver/operator/bundle/index with this PR. But after kubernetes-csi#817 the e2e will install the helm upstream driver version by default in BeforeSuite, it will impact our presubmit job smb-operator-e2e-extended, try to make it compatible in kubernetes-csi#854 .

$ oc get csv
NAME                              DISPLAY                        VERSION   REPLACES   PHASE
smb-csi-driver-operator.v4.18.0   CIFS/SMB CSI Driver Operator   4.18.0               Succeeded
$ oc rsh -c csi-driver smb-csi-driver-controller-856986f55c-jhj4l
sh-5.1# /bin/smbplugin -ver
Build Date: "2024-09-30T06:23:32Z"
Compiler: gc
Driver Name: smb.csi.k8s.io
Driver Version: v1.16.0
Git Commit: f46104191bf7fbf7907f0b0fac4f419fa75195fa
Go Version: go1.22.5 (Red Hat 1.22.5-1.el9) X:strictfipsruntime
Platform: linux/amd64

$ go test -v -timeout=0 ./test/e2e -ginkgo.v -ginkgo.timeout=1h
Ran 12 of 13 Specs in 632.966 seconds
SUCCESS! -- 12 Passed | 0 Failed | 0 Pending | 1 Skipped
You're using deprecated Ginkgo functionality:
=============================================
  Support for custom reporters has been removed in V2.  Please read the documentation linked to below for Ginkgo's new behavior and for a migration path:
  Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=2.17.1

--- PASS: TestE2E (632.97s)
PASS
ok      github.com/kubernetes-csi/csi-driver-smb/test/e2e       633.791s

@dfajmon
Copy link
Author

dfajmon commented Oct 7, 2024

the kubernetes-csi#854 has been merged can we follow up with this PR?
@Phaow

@Phaow
Copy link

Phaow commented Oct 8, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2024

@dfajmon: This pull request references STOR-2006 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Issue link:
https://issues.redhat.com/browse/STOR-2006

Diff to upstream v1.14.0:
kubernetes-csi/csi-driver-smb@v1.16.0...dfajmon:rebase-1.16.0

Changes between 1.14.0 (OCP 4.17) and 1.16.0 (OCP 4.18):
1.15.0

1.16.0

Full changelogs:
https://github.com/kubernetes-csi/csi-driver-smb/releases/tag/v1.15.0
https://github.com/kubernetes-csi/csi-driver-smb/releases/tag/v1.16.0

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Phaow
Copy link

Phaow commented Oct 8, 2024

the kubernetes-csi#854 has been merged can we follow up with this PR? @Phaow

Sure, sorry for late reply, just back from holiday.

@openshift-merge-bot openshift-merge-bot bot merged commit 1921c2a into openshift:master Oct 8, 2024
5 of 6 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-smb-csi-driver
This PR has been included in build ose-smb-csi-driver-container-v4.18.0-202410080242.p0.g1921c2a.assembly.stream.el9.
All builds following this will include this PR.

@dfajmon dfajmon deleted the rebase-1.16.0 branch October 8, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants