Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add host list filters #1786

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Add host list filters #1786

merged 1 commit into from
Jul 3, 2019

Conversation

jtomasek
Copy link

@jtomasek jtomasek commented Jun 21, 2019 •
edited
Loading

Depends on #1774, #1697

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 21, 2019
jtomasek
jtomasek commented Jun 21, 2019
View reviewed changes
frontend/packages/metal3-plugin/src/components/table-filters.ts Outdated
title: string;
};

type Filter = {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vojtechszocs Those types are common across all filters (IIUC), should I move them into @console/internal/components/factory/table-filters to make them widely available?

Copy link
Contributor

@mareklibra mareklibra Jun 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Within #1689, I am moving them under @console/shared (see 6729b58)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on that change

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 21, 2019
@spadgett spadgett added this to the v4.2 milestone Jun 21, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 24, 2019
@jtomasek
Copy link
Author

/test e2e-aws-console-olm

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2019
@jtomasek
Copy link
Author

jtomasek commented Jul 1, 2019

/test e2e-aws

1 similar comment
@jtomasek
Copy link
Author

jtomasek commented Jul 1, 2019

/test e2e-aws

spadgett
spadgett reviewed Jul 1, 2019
View reviewed changes
frontend/packages/metal3-plugin/src/components/table-filters.ts Outdated
HOST_STATUS_PROVISIONED,
} from '../constants';

const hostStatesToFilterMap = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest Object.freeze here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

frontend/packages/metal3-plugin/src/components/table-filters.ts Outdated
type: 'host-status',
selected: Object.keys(hostStatesToFilterMap),
reducer: getHostFilterStatus,
items: Object.keys(hostStatesToFilterMap).map((state) => ({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest _.map

Suggested change
items: Object.keys(hostStatesToFilterMap).map((state) => ({
items: _.map(hostStatesToFilterMap, ({title}, id) => ({ id, title })),

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

frontend/packages/metal3-plugin/src/components/table-filters.ts Outdated
id: state,
title: hostStatesToFilterMap[state].title,
})),
filter: (statuses, host) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add types when possible

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@honza
Copy link
Member

honza commented Jul 3, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza, jtomasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f2f6d91 into openshift:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mareklibra mareklibra mareklibra left review comments

@spadgett spadgett spadgett left review comments

@knowncitizen knowncitizen Awaiting requested review from knowncitizen

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@honza honza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.
7 participants
@jtomasek @honza @openshift-ci-robot @openshift-bot @spadgett @mareklibra @openshift-merge-robot