Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust modal height at landscape orientation so that buttons aren't beneath viewport on ios. #1229

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/public/components/modals/_modals.scss
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@
height: calc(100% - 20px); // subtract height margin-top 10px + margin-bottom 10px
outline: 0;

@media(min-width: $screen-sm-min) {
height: calc(100% - 60px); // subtract height margin-top 30px + margin-bottom 30px
@media(min-width: $screen-sm-min), (max-width: $screen-xs-max) and (orientation: landscape) {
height: calc(100% - 60px); // At desktop, subtract margin-top 30px + margin-bottom 30px OR in the case of mobile landscape orientation, subtract the height of ios url control bar, since its height is not taken into account when the viewport height is calculated on initial page load. This causes the modal to extend below the viewport and hide modal-footer buttons.
}
}

Expand Down