Skip to content

Commit

Permalink
Merge pull request #1229 from sg00dwin/modal-landscape-height-issue
Browse files Browse the repository at this point in the history
Adjust modal height at landscape orientation so that buttons aren't beneath viewport on ios.
  • Loading branch information
openshift-merge-robot authored Feb 28, 2019
2 parents 500b1c3 + 4dce5fa commit b1c3c16
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions frontend/public/components/modals/_modals.scss
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@
height: calc(100% - 20px); // subtract height margin-top 10px + margin-bottom 10px
outline: 0;

@media(min-width: $screen-sm-min) {
height: calc(100% - 60px); // subtract height margin-top 30px + margin-bottom 30px
@media(min-width: $screen-sm-min), (max-width: $screen-xs-max) and (orientation: landscape) {
height: calc(100% - 60px); // At desktop, subtract margin-top 30px + margin-bottom 30px OR in the case of mobile landscape orientation, subtract the height of ios url control bar, since its height is not taken into account when the viewport height is calculated on initial page load. This causes the modal to extend below the viewport and hide modal-footer buttons.
}
}

Expand Down

0 comments on commit b1c3c16

Please sign in to comment.