Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit roles/clusterroles for api-resource-collector #253

Merged
merged 1 commit into from
May 19, 2020

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented May 19, 2020

The OLM doesn't allow us to use pre-existing roles/clusterroles, nor
use aggregated roles either. So we need to define the roles explicitly.

See: operator-framework/operator-lifecycle-manager#732

The OLM doesn't allow us to use pre-existing roles/clusterroles, nor
use aggregated roles either. So we need to define the roles explicitly.

See: operator-framework/operator-lifecycle-manager#732
@JAORMX JAORMX requested a review from mrogers950 May 19, 2020 06:22
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2020
@jhrozek
Copy link
Contributor

jhrozek commented May 19, 2020

Since this is blocking the release, I'm going to lgtm the PR so that we can do the release, Ozz showed me the result in a tmate session. We can iterate on the patch later.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, jhrozek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@JAORMX JAORMX merged commit 4a3eb99 into openshift:master May 19, 2020
rhmdnd pushed a commit to rhmdnd/compliance-operator that referenced this pull request Mar 20, 2023
…cleanup

Fix test log about --skip-cleanup-error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants