-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set user tags on s3 bucket #84
Set user tags on s3 bucket #84
Conversation
coreydaley
commented
Nov 26, 2018
•
edited
Loading
edited
- Set installConfig.Platform.AWS.UserTags as tags on the created S3 bucket
@coreydaley please split this into two PRs, one for the usertags and the other for the managedstorage status field. |
Will split it up in the next push |
separate commits!=separate PRs. I was trying to help you expedite the merge since i expect the usertags PR to be less controversial than whatever discussion needs to happen around how we want to represent the ManagedStorage status. anyway add the nil checking that @wking suggested and i think this is lgtm, but i guess we'll see if @legionus or @dmage have any concerns on the ManagedStorage status field. |
@bparees I split this into two PRs now. ptal |
/lgtm thanks @coreydaley |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, coreydaley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |