Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.18] OCPBUGS-45039: operator/status: clear azure path fix job conditions on operator removal #1163

Open
wants to merge 2 commits into
base: release-4.18
Choose a base branch
from
Open

[release-4.18] OCPBUGS-45039: operator/status: clear azure path fix job conditions on operator removal #1163

wants to merge 2 commits into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1142

/assign flavianmissi

@flavianmissi
azurepathfix: continue reconciliation when storage isn't configured
6918d4f 
remove early return when .status.storage.azure is unset. this property
is cleared up when the operator managementState is set to Removed, and
in such cases the early return would stop the controller from clearing
up the conditions and deleting the job. without this check the
controller can still do its job, even when managementState is Removed.
@flavianmissi
clean up AzurePathFix controller, removing unecessary informers
d0356a0 
* drops use of the azurepathfixjob resource generator, as we only need
  to get and delete the job and we mostly benefit from the generator
  pattern when creating objects.

* remove uneccessary informers. those were needed when creating the job
  object, but are no longer relevant for only getting and deleting it.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 26, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-41903 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.18] OCPBUGS-45039: operator/status: clear azure path fix job conditions on operator removal

In response to this:

This is an automated cherry-pick of #1142

/assign flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-41903: operator/status: clear azure path fix job conditions on operator removal [release-4.18] OCPBUGS-45039: operator/status: clear azure path fix job conditions on operator removal Nov 26, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 26, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-45039, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-41903 to target a version in 4.19.0, but it targets "4.18" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1142

/assign flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign adambkaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hypershift-e2e-aks d0356a0 link false /test hypershift-e2e-aks
ci/prow/e2e-aws-operator d0356a0 link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@flavianmissi flavianmissi Awaiting requested review from flavianmissi

Assignees

@flavianmissi flavianmissi

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @flavianmissi