-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP certsignercontroller: avoid using resourceapply.ApplySecret #1362
base: master
Are you sure you want to change the base?
WIP certsignercontroller: avoid using resourceapply.ApplySecret #1362
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
69a7403
to
09f313c
Compare
This method makes an extra GET, which is costly for such a large secret. Instead it uses a version from cache, runs a single GET and uses server-side apply to update it
09f313c
to
970cadb
Compare
@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/081fe680-96da-11ef-91f4-cde4735e474b-0 |
@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a7c78740-96f5-11ef-8917-56e896fcf5d0-0 |
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/20169390-9790-11ef-9369-5b6a6b14fab2-0 |
This method makes an extra GET, which is costly for such a large secret. Instead it uses a version from cache, runs a single GET and uses server-side apply to update it