Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP certsignercontroller: avoid using resourceapply.ApplySecret #1362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vrutkovs
Copy link
Member

This method makes an extra GET, which is costly for such a large secret. Instead it uses a version from cache, runs a single GET and uses server-side apply to update it

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2024
@openshift-ci openshift-ci bot requested review from dusk125 and Elbehery October 25, 2024 11:36
Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign elbehery for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs force-pushed the more-protobuf-duplicate-all-certs-secret-fetch branch 4 times, most recently from 69a7403 to 09f313c Compare October 29, 2024 11:07
This method makes an extra GET, which is costly for such a large secret. Instead it uses a version from cache, runs a single GET and uses server-side apply to update it
@vrutkovs vrutkovs force-pushed the more-protobuf-duplicate-all-certs-secret-fetch branch from 09f313c to 970cadb Compare October 30, 2024 15:15
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/081fe680-96da-11ef-91f4-cde4735e474b-0

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a7c78740-96f5-11ef-8917-56e896fcf5d0-0

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 970cadb link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 970cadb link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-certrotation 970cadb link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-aws-ovn-etcd-scaling 970cadb link true /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-agnostic-ovn-upgrade 970cadb link true /test e2e-agnostic-ovn-upgrade
ci/prow/e2e-aws-etcd-recovery 970cadb link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-serial 970cadb link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

@vrutkovs: This PR was included in a payload test run from openshift/kubernetes#2124
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/20169390-9790-11ef-9369-5b6a6b14fab2-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant