-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1800437, Bug 1800470, Bug 1800477: Update getters to match upstream #30
Bug 1800437, Bug 1800470, Bug 1800477: Update getters to match upstream #30
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huffmanca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ee5de63
to
ef6a764
Compare
@huffmanca: This pull request references Bugzilla bug 1800477, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@jsafrane: This pull request references Bugzilla bug 1800477, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@jsafrane: This pull request references Bugzilla bug 1800477, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@huffmanca: All pull requests linked via external trackers have merged. Bugzilla bug 1800477 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.4 |
@huffmanca: new pull request created: #31 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Includes additional information for the
get
command for the VolumeSnapshot* CRDs. This is, effectively, a backport of kubernetes-csi/external-snapshotter#260 ; however, since we simply copy the CRDs I've copied the changes here.Does this PR introduce a user-facing change?: