Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-2642: manifests-gen: Allow overriding kustomize component path #228

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Oct 30, 2024

This PR adds the ability to locally override the path for Kustomize components within a CAPI provider repository.

This is required for openshift/cluster-api-provider-azure#322 so that the Azure Service Operator's Deployment arguments can be overridden to ignore handling CRDs.

Adding that modification directly in the Go code here would create a tighter coupling between this repository and the CAPZ one, and would be less flexible for future scenarios.

Also added a README file to explain some assumptions in the code base and document overriding the Kustomize component path.

@nrb
Copy link
Contributor Author

nrb commented Oct 30, 2024

Files generated with this code on my local machine can be seen in this commit: openshift/cluster-api-provider-azure@5cb8769

@damdo
Copy link
Member

damdo commented Oct 31, 2024

/retitle OCPCLOUD-2642: manifests-gen: Allow overriding kustomize component path

@openshift-ci openshift-ci bot changed the title CAPZ: Allow overriding kustomize component path OCPCLOUD-2642: manifests-gen: Allow overriding kustomize component path Oct 31, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 31, 2024

@nrb: This pull request references OCPCLOUD-2642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR adds the ability to locally override the path for Kustomize components within a CAPI provider repository.

This is required for openshift/cluster-api-provider-azure#322 so that the Azure Service Operator's Deployment arguments can be overridden to ignore handling CRDs.

Adding that modification directly in the Go code here would create a tighter coupling between this repository and the CAPZ one, and would be less flexible for future scenarios.

Also added a README file to explain some assumptions in the code base and document overriding the Kustomize component path.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 31, 2024
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest-required

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2024
Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2024
Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

@nrb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/regression-clusterinfra-cucushift-rehearse-capi-aws-ipi 8042f2c link false /test regression-clusterinfra-cucushift-rehearse-capi-aws-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 87f4fd2 into openshift:main Oct 31, 2024
17 of 18 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-capi-operator
This PR has been included in build ose-cluster-capi-operator-container-v4.18.0-202410311509.p0.g87f4fd2.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants