-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPCLOUD-2642: manifests-gen: Allow overriding kustomize component path #228
Conversation
Signed-off-by: Nolan Brubaker <[email protected]>
Files generated with this code on my local machine can be seen in this commit: openshift/cluster-api-provider-azure@5cb8769 |
/retitle OCPCLOUD-2642: manifests-gen: Allow overriding kustomize component path |
@nrb: This pull request references OCPCLOUD-2642 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest-required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nrb: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
87f4fd2
into
openshift:main
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-capi-operator |
This PR adds the ability to locally override the path for Kustomize components within a CAPI provider repository.
This is required for openshift/cluster-api-provider-azure#322 so that the Azure Service Operator's Deployment arguments can be overridden to ignore handling CRDs.
Adding that modification directly in the Go code here would create a tighter coupling between this repository and the CAPZ one, and would be less flexible for future scenarios.
Also added a README file to explain some assumptions in the code base and document overriding the Kustomize component path.