Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Keycloak e2e test improvements #714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NO-JIRA: Keycloak e2e test improvements #714

wants to merge 1 commit into from

Conversation

liouk
Copy link
Member

@liouk liouk commented Oct 10, 2024 •
edited
Loading

This PR investigates improvements that can be done to the Keycloak deployment to fix intermittent issues we have been having.

Improvements

  • start Keycloak in development mode, which uses a local cache instead of a distributed one (see here for more details)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 10, 2024
@openshift-ci-robot
Copy link
Contributor

@liouk: This pull request explicitly references no jira issue.

In response to this:

This PR investigates improvements that can be done to the Keycloak deployment to fix intermittent issues we have been having.

Improvements

  • set Keycloak cache to local instead of the default ispn which is a distributed cache

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2024
@openshift-ci openshift-ci bot requested review from deads2k and ibihim October 10, 2024 12:08
@liouk
Copy link
Member Author

liouk commented Oct 14, 2024

/test e2e-operator

3 similar comments
@liouk
Copy link
Member Author

liouk commented Oct 17, 2024

/test e2e-operator

@liouk
Copy link
Member Author

liouk commented Oct 17, 2024

/test e2e-operator

@liouk
Copy link
Member Author

liouk commented Oct 18, 2024

/test e2e-operator

@liouk liouk force-pushed the fix-keycloak-e2e branch 2 times, most recently from dcd3785 to f064518 Compare October 21, 2024 08:01
@liouk
Copy link
Member Author

liouk commented Oct 21, 2024

/test e2e-operator

@liouk liouk changed the title WIP: NO-JIRA: Keycloak e2e test improvements NO-JIRA: Keycloak e2e test improvements Oct 29, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

@liouk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-operator-integration 896904f link false /test test-operator-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ibihim
Copy link
Contributor

ibihim commented Nov 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibihim, liouk
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@ibihim ibihim Awaiting requested review from ibihim

Assignees

@ibihim ibihim

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liouk @openshift-ci-robot @ibihim