Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.17]: OKD-226: Dockerfile.rhel7: Add ARG TAGS=ocp #700

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from

Conversation

Prashanth684
Copy link
Contributor

Manual cherry-pick of #687 since auto cherry-pick was leading to a conflict.

Manual cherry-pick of openshift#687 since auto cherry-pick was leading to a
conflict.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 26, 2024

@Prashanth684: This pull request references OKD-226 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Manual cherry-pick of #687 since auto cherry-pick was leading to a conflict.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 26, 2024
@openshift-ci openshift-ci bot requested review from ibihim and liouk September 26, 2024 20:25
@ausil
Copy link

ausil commented Sep 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
Copy link
Contributor

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ausil, Prashanth684
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Prashanth684
Copy link
Contributor Author

/test e2e-operator

@xingxingxia
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 29, 2024
@ausil
Copy link

ausil commented Oct 2, 2024

/assign deads2k

@ausil
Copy link

ausil commented Oct 14, 2024

/test e2e-operator

@Prashanth684 Prashanth684 added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 18, 2024
@Prashanth684
Copy link
Contributor Author

/test e2e-operator

@Prashanth684
Copy link
Contributor Author

@deads2k could you stamp an approval for this please?

Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

@Prashanth684: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator 36a9412 link true /test e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants