Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-34307: Updating ose-cluster-authentication-operator-container image to be consistent with ART for 4.17 #686

Open
wants to merge 2 commits into
base: release-4.17
Choose a base branch
from
Open

OCPBUGS-34307: Updating ose-cluster-authentication-operator-container image to be consistent with ART for 4.17 #686

wants to merge 2 commits into from

Conversation

ibihim
Copy link
Contributor

@ibihim ibihim commented Aug 28, 2024 •
edited
Loading

What

Reopened the PR with a go mod vendor commit.

Why

The previous PR fails due to a change in the vendor folder, that is being triggered by a Go version bump in go.mod.
The reason for this behavior is unclear to me as the files exist for over a year already. Those are the test files that are being deleted:

deleted:    vendor/github.com/openshift/library-go/pkg/operator/apiserver/audit/testdata/allrequestbodies.yaml
deleted:    vendor/github.com/openshift/library-go/pkg/operator/apiserver/audit/testdata/audit-policies-cm-scenario-1.yaml
deleted:    vendor/github.com/openshift/library-go/pkg/operator/apiserver/audit/testdata/default.yaml
deleted:    vendor/github.com/openshift/library-go/pkg/operator/apiserver/audit/testdata/multipleCr.yaml
deleted:    vendor/github.com/openshift/library-go/pkg/operator/apiserver/audit/testdata/none.yaml
deleted:    vendor/github.com/openshift/library-go/pkg/operator/apiserver/audit/testdata/oauth.yaml
deleted:    vendor/github.com/openshift/library-go/pkg/operator/apiserver/audit/testdata/writerequestbodies.yaml

Ref

#673

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 28, 2024
@openshift-ci-robot
Copy link
Contributor

@ibihim: This pull request references Jira Issue OCPBUGS-34307, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-39037 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-39037 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @xingxingxia

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What

Reopened the PR with a go mod vendor commit.

Why

The previous PR fails due to a change in the vendor folder, that is being triggered by a Go version bump in go.mod.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 28, 2024
@deads2k
Copy link
Contributor

deads2k commented Aug 28, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2024
@xingxingxia
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 29, 2024
@ibihim
Copy link
Contributor Author

ibihim commented Aug 29, 2024

/retest-required

@liouk
Copy link
Member

liouk commented Aug 29, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ibihim, liouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibihim
Copy link
Contributor Author

ibihim commented Sep 2, 2024

/retest-required

4 similar comments
@ibihim
Copy link
Contributor Author

ibihim commented Sep 3, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 3, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 3, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 4, 2024

/retest-required

@ibihim ibihim mentioned this pull request Sep 4, 2024
Closed
@xingxingxia
Copy link
Contributor

/retest-required

1 similar comment
@ibihim
Copy link
Contributor Author

ibihim commented Sep 6, 2024

/retest-required

@ibihim ibihim mentioned this pull request Sep 6, 2024
Closed
@ibihim
Copy link
Contributor Author

ibihim commented Sep 9, 2024

/retest-required

5 similar comments
@ibihim
Copy link
Contributor Author

ibihim commented Sep 9, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 9, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 9, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 9, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 9, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 9, 2024

/retest-required

8 similar comments
@ibihim
Copy link
Contributor Author

ibihim commented Sep 10, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 10, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 10, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 10, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 10, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 10, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 10, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 10, 2024

/retest-required

@ibihim ibihim force-pushed the art-consistency-openshift-4.17-ose-cluster-authentication-operator branch from 84b118c to 44957df Compare September 10, 2024 13:10
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

New changes are detected. LGTM label has been removed.

@ibihim
Copy link
Contributor Author

ibihim commented Sep 10, 2024

/retest-required

7 similar comments
@ibihim
Copy link
Contributor Author

ibihim commented Sep 10, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 10, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 10, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 11, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 11, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 11, 2024

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Sep 11, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

@ibihim: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 44957df link false /test e2e-aws-single-node
ci/prow/e2e-operator 44957df link true /test e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xingxingxia xingxingxia Awaiting requested review from xingxingxia

@deads2k deads2k Awaiting requested review from deads2k

@liouk liouk Awaiting requested review from liouk

Assignees

@liouk liouk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ibihim @openshift-ci-robot @deads2k @xingxingxia @liouk @openshift-bot @openshift-merge-robot