Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actuator patches #5

Merged
merged 3 commits into from
Feb 1, 2019
Merged

Actuator patches #5

merged 3 commits into from
Feb 1, 2019

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Jan 30, 2019

We previously needed to apply this as patches in every consumer vendoring the upstream API
https://github.com/openshift/cluster-api-provider-aws/blob/master/Makefile#L47
Needs #4

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 30, 2019
@enxebre
Copy link
Member Author

enxebre commented Jan 30, 2019

/hold
cc @frobware @bison @ingvagabund

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 31, 2019
@enxebre enxebre removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2019
@enxebre enxebre mentioned this pull request Jan 31, 2019
Merged
@paulfantom
Copy link

/refresh
/retest

@paulfantom paulfantom mentioned this pull request Feb 1, 2019
Closed
@enxebre
Copy link
Member Author

enxebre commented Feb 1, 2019

/test images
/test unit

@enxebre
Copy link
Member Author

enxebre commented Feb 1, 2019

/test unit

@frobware
Copy link

frobware commented Feb 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2019
@ingvagabund
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2019
@enxebre
Copy link
Member Author

enxebre commented Feb 1, 2019

/test unit

1 similar comment
@enxebre
Copy link
Member Author

enxebre commented Feb 1, 2019

/test unit

@openshift-merge-robot openshift-merge-robot merged commit acabf52 into openshift:release-4.0 Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison Awaiting requested review from bison

@spangenberg spangenberg Awaiting requested review from spangenberg

Assignees

@frobware frobware

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@enxebre @paulfantom @frobware @ingvagabund @openshift-ci-robot @openshift-merge-robot