UPSTREAM: <carry>: openshift: Machine controller: drain node before machine deletion #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
|
/hold We need to wait until all the tests in openshift/cluster-api-provider-aws#174 pass (to verify the node draining is still functional). |
openshift-ci-robot
added
the
do-not-merge/hold
|
These are commits we want to carry on a rebase. Can you update the commits to follow |
ingvagabund
force-pushed
the
node-draining
branch
from
ce15a65 to
27e9496
Compare
ingvagabund
changed the title
|
/retest |
|
/test unit |
1 similar comment
|
/test unit |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
frobware
reviewed
Mar 12, 2019
…achine deletion The node draining code itself is imported from github.com/openshift/kubernetes-drain. At the same time it's currently impossible to use the controller-runtime client for node draining due to missing Patch operation (kubernetes-sigs/controller-runtime#235). Thus, the machine controller needs to initialize kubeclient as well in order to implement the node draining logic. Once the Patch operation is implemented, the draining logic can be updated to replace kube client with controller runtime client. Also, initialize event recorder to generate node draining event.
By running `dep ensure` followed by `make gazelle`.
ingvagabund
force-pushed
the
node-draining
branch
from
27e9496 to
a439d98
Compare
|
/lgtm |
ingvagabund
added a commit
to openshift/cluster-api-provider-kubemark
that referenced
this pull request
Mar 14, 2019
Node draining logic has been moved to the machine controller. See openshift/cluster-api#11 for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The node draining code itself is imported from github.com/openshift/kubernetes-drain.
At the same time it's currently impossible to use the controller-runtime client for node draining due to missing Patch operation (kubernetes-sigs/controller-runtime#235). Thus, the machine controller needs to initialize kubeclient as well in order to implement the node draining logic. Once the Patch operation is implemented, the draining logic can be updated to replace kube client with controller runtime client.
Also, initialize event recorder to generate node draining event.