OCPBUGS-44455: Merge https://github.com/kubernetes-sigs/cluster-api-provider-openstack:release-0.10 into release-4.17 #329
Conversation
![shiftstack-merge-bot[bot]](https://avatars.githubusercontent.com/u/48560946?s=60&v=4){kind=small}
This fixes linting issues in the release-0.10 branch, which only manifest when the toolchain is bumped to 1.23, as in the current default kubekins-e2e image used in prow jobs.
🌱 release-0.10: Pin GOTOOLCHAIN to go1.22.8
v1alpha6 PortOpts conversion was missing many fields, but this was hidden in the unit tests because the v1alpha6 restore function for the machine spec unconditionally restored all Ports. This change turns the unconditional restore of all ports in the machine spec into individual conversion of each port, then fixes all the resulting test failures by adding individual conversions and restores as required.
…ot/cherry-pick-2207-to-release-0.10 [release-0.10] 🐛 Fix conversion of v1alpha6 PortOpts
- Fixed issue where spec.bastion.spec.serverMetadata was not set in bastion. - Updated bastionToInstanceSpec to apply serverMetadata in InstanceSpec.
…n-metadata 🐛 Fix ServerMetadata Not Applied to Bastion in OpenStackCluster
|
Hi @shiftstack-merge-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
needs-ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
@shiftstack-merge-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retitle OCPBUGS-44455: Merge https://github.com/kubernetes-sigs/cluster-api-provider-openstack:release-0.10 into release-4.17 |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@shiftstack-merge-bot[bot]: This pull request references Jira Issue OCPBUGS-44455, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
|
@mandre: This pull request references Jira Issue OCPBUGS-44455, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
backport-risk-assessed
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@mandre: This pull request references Jira Issue OCPBUGS-44455, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
openshift-merge-bot
bot
merged commit d17a4a0
into
openshift:release-4.17
|
@shiftstack-merge-bot[bot]: Jira Issue OCPBUGS-44455: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-44455 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openstack-cluster-api-controllers |
No description provided.