Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revendor github.com/openshift/cluster-api--actuator-pkg #149

Closed

Conversation

zeenix
Copy link
Contributor

@zeenix zeenix commented Apr 24, 2019

It is hoped that this update will help with failing e2e tests.

It is hoped that this update will help with failing e2e tests.
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: michaelgugino

If they are not already assigned, you can assign the PR to them by writing /assign @michaelgugino in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 24, 2019
@zeenix
Copy link
Contributor Author

zeenix commented Apr 24, 2019

Hmm..I don't quite understand the govet test failure:

hack/go-vet.sh ./...
vendor/github.com/openshift/cluster-api-actuator-pkg/pkg/e2e/framework/common.go:9:2: cannot find package "github.com/openshift/cluster-autoscaler-operator/pkg/apis/autoscaling/v1" in any of:
	/go/src/github.com/openshift/cluster-api-provider-libvirt/vendor/github.com/openshift/cluster-autoscaler-operator/pkg/apis/autoscaling/v1 (vendor tree)
	/usr/local/go/src/github.com/openshift/cluster-autoscaler-operator/pkg/apis/autoscaling/v1 (from $GOROOT)
	/go/src/github.com/openshift/cluster-autoscaler-operator/pkg/apis/autoscaling/v1 (from $GOPATH)
vendor/github.com/openshift/cluster-api-actuator-pkg/pkg/e2e/framework/common.go:10:2: cannot find package "github.com/openshift/cluster-autoscaler-operator/pkg/apis/autoscaling/v1beta1" in any of:
	/go/src/github.com/openshift/cluster-api-provider-libvirt/vendor/github.com/openshift/cluster-autoscaler-operator/pkg/apis/autoscaling/v1beta1 (vendor tree)
	/usr/local/go/src/github.com/openshift/cluster-autoscaler-operator/pkg/apis/autoscaling/v1beta1 (from $GOROOT)
	/go/src/github.com/openshift/cluster-autoscaler-operator/pkg/apis/autoscaling/v1beta1 (from $GOPATH)
make: *** [vet] Error 1

github.com/openshift/cluster-autoscaler-operator/pkg/apis/autoscaling/v1beta1 is there under the vendor tree.

@zeenix
Copy link
Contributor Author

zeenix commented Apr 29, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

@zeenix: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/jenkins/e2e a1a0ef3 link /test e2e
ci/prow/unit a1a0ef3 link /test unit
ci/prow/actuator-pkg-staleness a1a0ef3 link /test actuator-pkg-staleness
ci/prow/govet a1a0ef3 link /test govet

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

@zeenix: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2019
@zeenix
Copy link
Contributor Author

zeenix commented May 14, 2019

Seems this go obsoleted by #151 .

@zeenix zeenix closed this May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants