Merge master from metal3-io/cluster-api-provider-baremetal. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
document dev environment setup
Replace the vendored version of the baremetal-operator code with the one from the new location, which includes corrected imports. Make all of the local code updates needed.
rename metalkube to metal3
A discovered host is not available but also does not have a machineRef set, so the pointer is nil.
handle discovered hosts in chooseHost
Discovered hosts are not ready and have an error message. Add a unit test with a host like that so we can ensure we don't have a problem ignoring them.
add unit test to deal with unprovisioned host with error
The values passed in with the ProviderSpec were previously hard-coded. Any user of Machines or MachineSets with this controller will need to start including a suitable ProviderSpec.
Adds ProviderSpec with settings for image and userdata.
This matches what the baremetal-operator uses by default, as well.
Use the metal3 namespace by default.
Use the metal3 namespace for the components built from the cluster-api repository, as well.
Use metal3 namepsace for cluster-api components.
cluster-api-provider-baremetal-controller-manager-metrics-service is too long. s/service/svc/ gets it under the limit.
Update to match the name of the binary in the container image we build.
This constant came from the sample provider implementation in cluster-api docs. It was missed when changing the sample to use "baremetal" everywhere instead of the sample "solas" provider.
Fix ProviderName to be "baremetal".
This syncs with master of cluster-api, which closes metal3-io#71.
Add API docs.
Update to latest master from cluster-api.
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
6 tasks
russellb
added a commit
to russellb/release
that referenced
this pull request
May 17, 2019
The upstream org for this repo moved from metalkube/ to metal3-io/. The follow openshift PR depends on this update to the canonical go repo: openshift/cluster-api-provider-baremetal#26
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, russellb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.