Bug 1910318: Ensure original conditions aren't mutated during reconcile

[JoelSpeed]

Vendor update for fix:

If the original conditions are just fetched directly from the machine, this is a reference to a slice. This slice can then be updated by updating the machine conditions. We need to instead have a copy, else the comparison later won't work.

Also, if we mark the condition true then call the actuator update, this can cause issues as the actuator may also patch the machine (eg for providerID). So this needs to come after.

Tested manually on AWS.

[openshift-ci-robot]

@JoelSpeed: This pull request references Bugzilla bug 1910318, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 1910318: Ensure original conditions aren't mutated during reconcile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@JoelSpeed: This pull request references Bugzilla bug 1910318, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Bug 1910318: Ensure original conditions aren't mutated during reconcile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lobziik]

/lgtm

[Danil-Grigorev]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Danil-Grigorev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@JoelSpeed: Some pull requests linked via external trackers have merged:

• openshift/cluster-api-provider-aws#392
• openshift/cluster-api-provider-aws#396
• openshift/cluster-api-provider-azure#207
• openshift/cluster-api-provider-azure#211
• openshift/cluster-api-provider-gcp#152

The following pull requests linked via external trackers have not merged:

• openshift/cluster-api-provider-gcp#155 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1910318 has not been moved to the MODIFIED state.

In response to this:

Bug 1910318: Ensure original conditions aren't mutated during reconcile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.