Update awsmachine providerID and instanceID immediately after ec2:Run… #493
Conversation
…Instances is called This mitigates issues caused by falling back to tag-based searching for EC2 instances in case future AWS calls fail, such as attaching ENIs to security groups or tagging ENIs. Signed-off-by: Michael Shen <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@damdo When are we next rebasing? Will this commit be included in the rebase? |
|
@JoelSpeed I asked Richard if we can add them to the next minor and patch releases. |
|
As soon as one or the other are out, I'll make sure to downstream them through a rebase |
|
@damdo any estimate on when this will make it into the downstream? |
|
/test verify-commits |
|
@Patryk-Stefanski: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@Patryk-Stefanski We are planning the next CAPA upstream release (v2.4.0) to be next week. Then it'll take a day or two to downstream it. |
|
@damdo did this make it into the downstream? |
|
It released upstream, we are in the process of downstreaming it here #499 |
|
@Patryk-Stefanski we merged the PR to downstream CAPA 2.4 which should contain this fix. Let me know if it is there as expected, so we can close this PR. Thanks! |
|
@damdo we are seeing issues that need this fix more prominently, whats the best way to go about having this also backported to 4.15 and 4.14? |
|
/cherry-pick release-4.15 |
|
@damdo: cannot cherry-pick an unmerged PR In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Patryk-Stefanski we normally don't bump upstream patch releases to earlier release branches. Please remeber to follow the |
This mitigates issues caused by falling back to tag-based searching for EC2 instances in case future AWS calls fail within CreateInstance(), such as attaching ENIs to security groups or tagging ENIs.
Ref kubernetes-sigs/#4670