Refactor conditions logic #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelSpeed
reviewed
Mar 17, 2020
pkg/actuators/machine/utils.go
Outdated
| func conditionFailed() providerconfigv1.AWSMachineProviderCondition { | ||
| return providerconfigv1.AWSMachineProviderCondition{ | ||
| Type: providerconfigv1.MachineCreation, | ||
| Status: corev1.ConditionTrue, |
There was a problem hiding this comment.
Should be false?
Suggested change
| Status: corev1.ConditionTrue, | |
| Status: corev1.ConditionFalse, |
| type AWSMachineProviderConditionReason string | ||
|
|
||
| const ( | ||
| // MachineCreationSucceeded indicates machine creation success |
There was a problem hiding this comment.
Nit: should have period at end
Suggested change
| // MachineCreationSucceeded indicates machine creation success | |
| // MachineCreationSucceeded indicates machine creation success. |
| @@ -60,6 +60,16 @@ const ( | |||
| MachineCreation AWSMachineProviderConditionType = "MachineCreation" | |||
| ) | |||
|
|
|||
| // AWSMachineProviderConditionReason is reason for the condition's last transition | |||
There was a problem hiding this comment.
Nit: should have period at end
Suggested change
| // AWSMachineProviderConditionReason is reason for the condition's last transition | |
| // AWSMachineProviderConditionReason is reason for the condition's last transition. |
| const ( | ||
| // MachineCreationSucceeded indicates machine creation success | ||
| MachineCreationSucceeded AWSMachineProviderConditionReason = "MachineCreationSucceeded" | ||
| // MachineCreationFailed indicates machine creation fail |
There was a problem hiding this comment.
Nit: consistency
Suggested change
| // MachineCreationFailed indicates machine creation fail | |
| // MachineCreationFailed indicates machine creation failure. |
|
@JoelSpeed fixed |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor conditions logic and make it more simple. PR also contains a commit that removes double imports.