Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.3] Bug 1782176: Ensure Spec.ProviderID is not empty string #281

Merged
merged 1 commit into from
Dec 11, 2019
Merged

[release-4.3] Bug 1782176: Ensure Spec.ProviderID is not empty string #281

merged 1 commit into from
Dec 11, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #280

/assign enxebre

@michaelgugino
Ensure Spec.ProviderID is not empty string
ba72c04 
If the Spec.ProviderID field is present but an empty string,
we may encounter issues.  This is particularly the case in
DR scenarios when a user is attempting to copy an existing
machine in attempt to create one.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 11, 2019
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1781339, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1781339 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1781339: Ensure Spec.ProviderID is not empty string

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2019
@enxebre enxebre changed the title [release-4.3] Bug 1781339: Ensure Spec.ProviderID is not empty string [release-4.3] Bug 1782176: Ensure Spec.ProviderID is not empty string Dec 11, 2019
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 11, 2019
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1782176, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[release-4.3] Bug 1782176: Ensure Spec.ProviderID is not empty string

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre
Copy link
Member

enxebre commented Dec 11, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

@enxebre: This pull request references Bugzilla bug 1782176, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bison
bison approved these changes Dec 11, 2019
View reviewed changes
Copy link

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2171345 into openshift:release-4.3 Dec 11, 2019
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1782176 has been moved to the MODIFIED state.

In response to this:

[release-4.3] Bug 1782176: Ensure Spec.ProviderID is not empty string

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison bison approved these changes

@frobware frobware Awaiting requested review from frobware

Assignees

@bison bison

@enxebre enxebre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @enxebre @bison @openshift-merge-robot @michaelgugino