Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record machine events #109

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Record machine events #109

merged 1 commit into from
Dec 3, 2018

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Nov 24, 2018 •
edited
Loading

Record important error messages as events so they can be reported when describing a machine object.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 24, 2018
@ingvagabund
Copy link
Member Author

/retest

frobware
frobware requested changes Nov 26, 2018
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@enxebre
Copy link
Member

enxebre commented Nov 26, 2018 •
edited by frobware
Loading

5666d66 lgtm, let's make sure we agree on #107 details

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 28, 2018
@ingvagabund ingvagabund changed the title Record events Record machine events Nov 28, 2018
@bison
Copy link

bison commented Nov 28, 2018

This seem good. My one comment is mostly a style thing, which I hesitate to even bring up, but this makes a bunch of the lines extremely long. Like ~ 200 characters or more. I have a big 4k monitor and I can barely fit a whole line on the screen... I personally find that pretty hard to read.

A lot of the parameters are repeated. I feel like we could make some helpers / wrappers that made things a little more readable.

@ingvagabund
Copy link
Member Author

/retest

1 similar comment
@ingvagabund
Copy link
Member Author

/retest

@enxebre
Copy link
Member

enxebre commented Nov 29, 2018

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2018
@ingvagabund
Record machine events
11ccad4 
Record important error messages as events so they can be
reported when describing a machine object.
@ingvagabund
Copy link
Member Author

/retest

paulfantom
paulfantom approved these changes Dec 3, 2018
View reviewed changes
Copy link

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2018
@ingvagabund
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit fb5c960 into openshift:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware frobware requested changes

@paulfantom paulfantom paulfantom approved these changes

@bison bison Awaiting requested review from bison

@spangenberg spangenberg Awaiting requested review from spangenberg

Assignees

@paulfantom paulfantom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ingvagabund @enxebre @bison @openshift-ci-robot @frobware @paulfantom @openshift-merge-robot