Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29012: Improvements to client timeouts to prevent hangs #116

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

JoelSpeed
Copy link

We've observed some hanging where the Azure provider is taking a long time to remove LBs. It appears that this is due to the calls getting stuck and eventually getting killed at the kernel level.

This PR picks two upstream PRs to determine if they are resolving our issues.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 29, 2024
@openshift-ci-robot
Copy link

@JoelSpeed: This pull request references Jira Issue OCPBUGS-29012, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

We've observed some hanging where the Azure provider is taking a long time to remove LBs. It appears that this is due to the calls getting stuck and eventually getting killed at the kernel level.

This PR picks two upstream PRs to determine if they are resolving our issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from sunzhaohua2, damdo and elmiko April 29, 2024 10:33
@JoelSpeed
Copy link
Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-azure-sdn-upgrade
10

Copy link

openshift-ci bot commented Apr 29, 2024

@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-azure-sdn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/10e59a50-0614-11ef-8c82-e84f5d4705ac-0

@JoelSpeed
Copy link
Author

Had to re-push as I messed up the commit message format

But, reviewing the periodic aggregate, I can see no evidence of the long timeouts here, so I think we should merge and start backporting this.

@nrb
Copy link

nrb commented Apr 29, 2024

/retest

Copy link

openshift-ci bot commented Apr 29, 2024

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@JoelSpeed: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@JoelSpeed
Copy link
Author

/approve

Copy link

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0e95532 into openshift:master Apr 30, 2024
8 checks passed
@openshift-ci-robot
Copy link

@JoelSpeed: Jira Issue OCPBUGS-29012: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29012 has been moved to the MODIFIED state.

In response to this:

We've observed some hanging where the Azure provider is taking a long time to remove LBs. It appears that this is due to the calls getting stuck and eventually getting killed at the kernel level.

This PR picks two upstream PRs to determine if they are resolving our issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@JoelSpeed: new pull request created: #118

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-cloud-controller-manager-container-v4.16.0-202404301345.p0.g0e95532.assembly.stream.el9 for distgit ose-azure-cloud-controller-manager.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.16.0-0.nightly-2024-05-01-111315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants