-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29012: Improvements to client timeouts to prevent hangs #116
OCPBUGS-29012: Improvements to client timeouts to prevent hangs #116
Conversation
@JoelSpeed: This pull request references Jira Issue OCPBUGS-29012, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-azure-sdn-upgrade |
@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/10e59a50-0614-11ef-8c82-e84f5d4705ac-0 |
0921cca
to
77d95e6
Compare
Had to re-push as I messed up the commit message format But, reviewing the periodic aggregate, I can see no evidence of the long timeouts here, so I think we should merge and start backporting this. |
/retest |
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherry-pick release-4.15 |
@JoelSpeed: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks!
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JoelSpeed: Jira Issue OCPBUGS-29012: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-29012 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@JoelSpeed: new pull request created: #118 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-azure-cloud-controller-manager-container-v4.16.0-202404301345.p0.g0e95532.assembly.stream.el9 for distgit ose-azure-cloud-controller-manager. |
Fix included in accepted release 4.16.0-0.nightly-2024-05-01-111315 |
We've observed some hanging where the Azure provider is taking a long time to remove LBs. It appears that this is due to the calls getting stuck and eventually getting killed at the kernel level.
This PR picks two upstream PRs to determine if they are resolving our issues.