Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry replacer: Add explanation in PR body #995

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Registry replacer: Add explanation in PR body #995

merged 1 commit into from
Jul 9, 2020

Conversation

alvaroaleman
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2020
petr-muller
petr-muller approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files a PR for a tool to add descriptions in PRs, provides no description on that PR, like a boss :trollface: 🤣

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit 61c352e into openshift:master Jul 9, 2020
@alvaroaleman
Copy link
Contributor Author

Files a PR for a tool to add descriptions in PRs, provides no description on that PR, like a bos

I only write self-explaining code 🙃

wking added a commit to wking/ci-tools that referenced this pull request Nov 16, 2020
@wking
cmd/registry-replacer: Fix "dircetive" -> "directive" typo
9b292e5 
Typo landed with the pruning line in d98daf9 (Registry replacer:
Add explanation in PR body, 2020-07-09, openshift#995).
@wking wking mentioned this pull request Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-muller petr-muller petr-muller approved these changes

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@droslean droslean Awaiting requested review from droslean

Assignees

@petr-muller petr-muller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alvaroaleman @openshift-ci-robot @petr-muller @openshift-merge-robot