Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the golang-lint issue #531

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

xiaoyu74
Copy link
Contributor

Upgrade golang-lint version

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@bmeng
Copy link
Contributor

bmeng commented Sep 30, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 45.73%. Comparing base (2fe6b30) to head (66bff68).

Files with missing lines Patch % Lines
pkg/healthcheck/check_proxy.go 50.00% 2 Missing ⚠️
pkg/healthcheck/check_vpn.go 50.00% 2 Missing ⚠️
pkg/healthcheck/connectivity_checks.go 0.00% 1 Missing ⚠️
pkg/monitoring/monitoring.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #531   +/-   ##
=======================================
  Coverage   45.73%   45.73%           
=======================================
  Files          82       82           
  Lines        6236     6236           
=======================================
  Hits         2852     2852           
  Misses       3030     3030           
  Partials      354      354           
Flag Coverage Δ
45.73% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/healthcheck/connectivity_checks.go 8.43% <0.00%> (ø)
pkg/monitoring/monitoring.go 39.47% <0.00%> (ø)
pkg/healthcheck/check_proxy.go 72.34% <50.00%> (ø)
pkg/healthcheck/check_vpn.go 72.97% <50.00%> (ø)

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@xiaoyu74 xiaoyu74 changed the title Upgrade golang-lint version Fixing the golang-lint issue Sep 30, 2024
@xiaoyu74 xiaoyu74 changed the title Fixing the golang-lint issue Fix the golang-lint issue Sep 30, 2024
@bmeng
Copy link
Contributor

bmeng commented Sep 30, 2024

/label tide/merge-method-squash

remove verbose

Manually fix the lint errors

FIx the lint errors

fixing more lint errors
Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

@xiaoyu74: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xiaoyu74
Copy link
Contributor Author

/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

@xiaoyu74: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@feichashao
Copy link
Contributor

/approve

@bmeng
Copy link
Contributor

bmeng commented Sep 30, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, feichashao, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bmeng,feichashao,xiaoyu74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 10a2781 into openshift:main Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants