-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the golang-lint issue #531
Conversation
/lgtm |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
=======================================
Coverage 45.73% 45.73%
=======================================
Files 82 82
Lines 6236 6236
=======================================
Hits 2852 2852
Misses 3030 3030
Partials 354 354
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ed5f4f0
to
8ca4ea3
Compare
/label tide/merge-method-squash |
fcca604
to
435e0a3
Compare
remove verbose Manually fix the lint errors FIx the lint errors fixing more lint errors
19f130d
to
66bff68
Compare
@xiaoyu74: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
@xiaoyu74: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmeng, feichashao, xiaoyu74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Upgrade golang-lint version