-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD-24269: Add cluster login support via OHSS card #478
OSD-24269: Add cluster login support via OHSS card #478
Conversation
84731c0
to
a9ed1f9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
==========================================
+ Coverage 45.50% 45.71% +0.20%
==========================================
Files 71 72 +1
Lines 5900 5954 +54
==========================================
+ Hits 2685 2722 +37
- Misses 2878 2888 +10
- Partials 337 344 +7
|
59f076d
to
368a5d7
Compare
368a5d7
to
1278cdf
Compare
@samanthajayasinghe: This pull request references OSD-24269 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
455a139
to
b616ac9
Compare
pkg/elevate/England
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this file for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit test leftovers :)
I hit an error,
let me send you the OHSS ticket number offline. |
b616ac9
to
48374ba
Compare
ahh ..nasty last-minute refactor mistake :( |
48374ba
to
252cbea
Compare
/label tide/merge-method-squash |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feichashao, samanthajayasinghe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@samanthajayasinghe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
feature
What this PR does / Why we need it?
Login cluster via JIRA ID
Which Jira/Github issue(s) does this PR fix?
Resolves #
Special notes for your reviewer
Unit Test Coverage
Guidelines
Test coverage checks
Pre-checks (if applicable)