-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD-22639: prompt, store and reuse elevate reason #406
Conversation
@Tof1973: This pull request references OSD-22639 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
- Coverage 44.74% 44.57% -0.18%
==========================================
Files 62 63 +1
Lines 5113 5243 +130
==========================================
+ Hits 2288 2337 +49
- Misses 2510 2585 +75
- Partials 315 321 +6
|
9433e7b
to
28cbc22
Compare
I'll give my +1 to this here - however it will be up to the backplane CLI maintainers to review further and merge. /lgtm |
This is not a blocker, but what if include |
I initially have not updated README, as there were no elevate section, but here I created a new dedicated elevate section with all details... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Tof1973!
All of this makes sense to me - but there's just a few nits in readme related to typos that are simple fixes. I also have tried testing it and can't quite get it to work the way it is expected to in the readme - see this slack thread: https://redhat-internal.slack.com/archives/C016S65RNG5/p1714745369106709?thread_ts=1714393862.376999&cid=C016S65RNG5
ca7554a
to
bb3749b
Compare
@Tof1973: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Tof1973: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorakemp, iamkirkbater, Tof1973 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorakemp, iamkirkbater, Tof1973 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
feature/documentation/unit-test
What this PR does / Why we need it?
OSD-22639
When running ocm-backplate elevate with an empty string as reason, a prompt will be displayed (if possible) to request the reason.
When a reason is provided (as first argument, on prompt or from previous context), it will be stored in cluster context in order that if a reason is needed for elevation within the following 20 min for the same cluster, no prompt will be displayed and the stored context will be used.
Which Jira/Github issue(s) does this PR fix?
Resolves OSD-22639
Special notes for your reviewer
After this change, we will be able to update SOPs using elevate to specify an empty reason, and command will prompt for the reason.
Pre-checks (if applicable)