Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSD-21348] Add Test Cases for Helper Function of elevate cmd #394

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

itsmitul9
Copy link
Contributor

@itsmitul9 itsmitul9 commented Apr 10, 2024

What type of PR is this?

(unit-test)

What this PR does / Why we need it?

Write test cases using BDD framework gingko

Which Jira/Github issue(s) does this PR fix?

OSD-21348

Resolves #

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

@itsmitul9: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.50%. Comparing base (996628a) to head (5360fb6).
Report is 34 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   47.98%   44.50%   -3.49%     
==========================================
  Files          56       62       +6     
  Lines        4272     5159     +887     
==========================================
+ Hits         2050     2296     +246     
- Misses       1900     2547     +647     
+ Partials      322      316       -6     

see 11 files with indirect coverage changes

@samanthajayasinghe
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itsmitul9, samanthajayasinghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6be5130 into openshift:main Apr 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants