OCPBUGS-33038: Rebase v1.29.5 for OCP 4.15

[RomanBednar]

Diff to upstream v1.29.5:
kubernetes-sigs/azurefile-csi-driver@v1.29.5...RomanBednar:azure-file-csi-driver:rebase-v1.29.5-ocp4.15

Notable changes:

• [release-1.29] feat: support workload identity setting in static PV mount kubernetes-sigs/azurefile-csi-driver#1647
• [release-1.29] fix: workload identity did not work kubernetes-sigs/azurefile-csi-driver#1785

@openshift/storage

[openshift-ci]

@RomanBednar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	9e6762e	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sdodson]

/jira refresh

[openshift-ci-robot]

@sdodson: This pull request references Jira Issue OCPBUGS-33038, which is invalid:

• expected dependent Jira Issue OCPBUGS-32785 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[RomanBednar]

/retest-required

[jsafrane]

/lgtm

[jsafrane]

/label cherry-pick-approved

[openshift-ci]

@jsafrane: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[duanwei33]

/label cherry-pick-approved

[RomanBednar]

/unhold

[duanwei33]

pre-merge verified with this open PR and openshift/azure-file-csi-driver-operator#103:
build 4.15.0-0.ci,openshift/azure-file-csi-driver#65,openshift/azure-file-csi-driver-operator#103

Followed https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/master/docs/workload-identity-static-pv-mount.md to test static provision with PV, the pod with azure file volume gets running:

$ oc get pod
NAME                      READY   STATUS    RESTARTS   AGE
statefulset-azurefile-0   1/1     Running   0          74m

$ oc rsh statefulset-azurefile-0 
$ df -h | grep azure
//wduantestshare.file.core.windows.net/wduantest  100T  192K  100T   1% /mnt/azurefile
$ touch /mnt/azurefile/415-premerge
$ ls /mnt/azurefile
415-premerge  outfile

$ oc get pv pv-azurefile -o yaml | yq .spec.csi
driver: file.csi.azure.com
volumeAttributes:
  clientID: 8b57a4f3-3a24-42bc-9dda-2507a9f6b8e4
  resourcegroup: wduan-share
  shareName: wduantest2
  storageaccount: wduantestshare
volumeHandle: wduantestshare-wduantest2

In the log we see the service account token is used to get the account key during NodePublishVolume:

I0506 11:58:16.896151       1 utils.go:77] GRPC call: /csi.v1.Node/NodeStageVolume
I0506 11:58:16.896175       1 utils.go:78] GRPC request: {"staging_target_path":"/var/lib/kubelet/plugins/kubernetes.io/csi/file.csi.azure.com/dbe10a3e863ebf7788bc4e5747d9ef072f254c092936b01d5475a3560a54a311/globalmount","volume_capability":{"AccessType":{"Mount":{"mount_flags":["dir_mode=0777","file_mode=0777","uid=0","gid=0","mfsymlinks","cache=strict","nosharesock"],"volume_mount_group":"1000700000"}},"access_mode":{"mode":5}},"volume_context":{"clientID":"8b57a4f3-3a24-42bc-9dda-2507a9f6b8e4","resourcegroup":"wduan-share","shareName":"wduantest2","storageaccount":"wduantestshare"},"volume_id":"wduantestshare-wduantest2"}
I0506 11:58:16.896469       1 nodeserver.go:173] Skip NodeStageVolume for volume(wduantestshare-wduantest2) since clientID 8b57a4f3-3a24-42bc-9dda-2507a9f6b8e4 is provided but service account token is empty

......
I0506 11:58:16.923523       1 utils.go:77] GRPC call: /csi.v1.Node/NodePublishVolume
I0506 11:58:16.923898       1 azurefile.go:799] clientID(8b57a4f3-3a24-42bc-9dda-2507a9f6b8e4) is specified, use service account token to get account key

[duanwei33]

/label qe-approved
/label cherry-pick-approved

[openshift-ci-robot]

@RomanBednar: This pull request references Jira Issue OCPBUGS-33038, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.z) matches configured target version for branch (4.15.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-32785 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-32785 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

Diff to upstream v1.29.5:
kubernetes-sigs/azurefile-csi-driver@v1.29.5...RomanBednar:azure-file-csi-driver:rebase-v1.29.5-ocp4.15

Notable changes:

• [release-1.29] feat: support workload identity setting in static PV mount kubernetes-sigs/azurefile-csi-driver#1647
• [release-1.29] fix: workload identity did not work kubernetes-sigs/azurefile-csi-driver#1785

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@RomanBednar: Jira Issue OCPBUGS-33038: Some pull requests linked via external trackers have merged:

• openshift/azure-file-csi-driver#65

The following pull requests linked via external trackers have not merged:

• openshift/azure-file-csi-driver-operator#103 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-33038 has not been moved to the MODIFIED state.

In response to this:

Diff to upstream v1.29.5:
kubernetes-sigs/azurefile-csi-driver@v1.29.5...RomanBednar:azure-file-csi-driver:rebase-v1.29.5-ocp4.15

Notable changes:

• [release-1.29] feat: support workload identity setting in static PV mount kubernetes-sigs/azurefile-csi-driver#1647
• [release-1.29] fix: workload identity did not work kubernetes-sigs/azurefile-csi-driver#1785

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-file-csi-driver-container-v4.15.0-202405061250.p0.gdc463da.assembly.stream.el9 for distgit azure-file-csi-driver.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2024-05-08-090106