-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-12560: STOR-1160: Rebase to v1.28.0 for OCP 4.14 #29
OCPBUGS-12560: STOR-1160: Rebase to v1.28.0 for OCP 4.14 #29
Conversation
doc: cut v1.25.1 release
doc: Fix URL to azure-files-csi driver doc in README.md
…er-version fix: incorrect driver version in CSIDriver
…i-channel-account-creation feat: add support for SMB Multi-channels in premium account creation
fix: buildx issue with provenance disabled
fix: switch base image to fix CVEs
doc: rephrase
…-lib chore: remove dependency on golang.org/x/text specific version
…ror-help-link feat: append help link when there is mount error
doc: cut v1.26.0 release
…orceumount fix: remove forceUmount and lazyUmount
@RomanBednar: This pull request references STOR-1160 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
I think the unit test is confused by running in a Kubernetes cluster - it constructs a Kubernetes client from azure-file-csi-driver/vendor/k8s.io/client-go/tools/clientcmd/client_config.go Lines 604 to 609 in 817a13b
It looks like kubernetes-sigs#1182 has broken it. IMO, the tests should not set |
aa5fa15
to
3fc3f0b
Compare
Cherry-picked kubernetes-sigs#1294 from upstream, CI should be ok now. /unhold |
/label docs-approved |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@RomanBednar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
QE checked the pre-submit CI all passed and the coverage looks good. |
@RomanBednar: Jira Issue OCPBUGS-12560: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-12560 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Diff to upstream v1.25.1:
kubernetes-sigs/azurefile-csi-driver@v1.28.0...RomanBednar:rebase-v1.28.0
Notable upstream features since v1.25.1 (OCP 4.13):
cc @openshift/storage