Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-12560: STOR-1160: Rebase to v1.28.0 for OCP 4.14 #29

Merged
merged 168 commits into from
Jun 19, 2023

Conversation

RomanBednar
Copy link

andyzhangx and others added 30 commits January 18, 2023 08:03
doc: Fix URL to azure-files-csi driver doc in README.md
…er-version

fix: incorrect driver version in CSIDriver
…i-channel-account-creation

feat: add support for SMB Multi-channels in premium account creation
…-lib

chore: remove dependency on golang.org/x/text specific version
…ror-help-link

feat: append help link when there is mount error
…orceumount

fix: remove forceUmount and lazyUmount
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 26, 2023

@RomanBednar: This pull request references STOR-1160 which is a valid jira issue.

In response to this:

Diff to upstream v1.25.1:
kubernetes-sigs/azurefile-csi-driver@v1.28.0...RomanBednar:rebase-v1.28.0

Notable upstream features since v1.25.1 (OCP 4.13):

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jsafrane and tsmetana May 26, 2023 13:08
@jsafrane
Copy link

/retest

@jsafrane
Copy link

I think the unit test is confused by running in a Kubernetes cluster - it constructs a Kubernetes client from /var/run/secrets/kubernetes.io/serviceaccount/token:

func (config *inClusterClientConfig) Possible() bool {
fi, err := os.Stat("/var/run/secrets/kubernetes.io/serviceaccount/token")
return os.Getenv("KUBERNETES_SERVICE_HOST") != "" &&
os.Getenv("KUBERNETES_SERVICE_PORT") != "" &&
err == nil && !fi.IsDir()
}

It looks like kubernetes-sigs#1182 has broken it. IMO, the tests should not set KUBERNETES_SERVICE_HOST / KUBERNETES_SERVICE_PORT. Can you please fix it upstream?

@RomanBednar RomanBednar changed the title STOR-1160: Rebase to v1.28.0 for OCP 4.14 WIP: STOR-1160: Rebase to v1.28.0 for OCP 4.14 Jun 6, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2023
@RomanBednar
Copy link
Author

Cherry-picked kubernetes-sigs#1294 from upstream, CI should be ok now.

/unhold

@RomanBednar RomanBednar changed the title WIP: STOR-1160: Rebase to v1.28.0 for OCP 4.14 STOR-1160: Rebase to v1.28.0 for OCP 4.14 Jun 8, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2023
@RomanBednar
Copy link
Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jun 13, 2023
@jsafrane
Copy link

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 70ae495 into openshift:master Jun 19, 2023
@duanwei33
Copy link

QE checked the pre-submit CI all passed and the coverage looks good.

@jsafrane jsafrane changed the title STOR-1160: Rebase to v1.28.0 for OCP 4.14 OCPBUGS-12560: STOR-1160: Rebase to v1.28.0 for OCP 4.14 Jul 18, 2023
@openshift-ci-robot
Copy link

@RomanBednar: Jira Issue OCPBUGS-12560: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-12560 has been moved to the MODIFIED state.

In response to this:

Diff to upstream v1.25.1:
kubernetes-sigs/azurefile-csi-driver@v1.28.0...RomanBednar:rebase-v1.28.0

Notable upstream features since v1.25.1 (OCP 4.13):

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.