Bug 1863055: CSI drivers should tolerate any taints #71
Conversation
So masters can use PVCs.
openshift-ci-robot
added
bugzilla/severity-medium
|
@jsafrane: This pull request references Bugzilla bug 1863055, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/retest |
| @@ -16,8 +16,7 @@ spec: | |||
| serviceAccount: aws-ebs-csi-driver-node-sa | |||
| priorityClassName: system-node-critical | |||
| tolerations: | |||
| - key: CriticalAddonsOnly | |||
| operator: Exists | |||
| - operator: Exists | |||
There was a problem hiding this comment.
IIRC this is tolerating any taints regardless of the key.
IMO we only want to tolerate the node-role.kubernetes.io/master key:
# Get one of my master nodes
oc get node/ip-10-0-130-8.us-east-2.compute.internal -o json | jq .spec.taints
[
{
"effect": "NoSchedule",
"key": "node-role.kubernetes.io/master"
}
]As in:
tolerations:
- key: node-role.kubernetes.io/master
effect: NoSchedule
There was a problem hiding this comment.
Tolerating everything is probably the best thing to do, because we don't know what node could want to run a pod with a PVC provided by the driver.
This is the same as image registry or SDN DaemonSets that tolerate everything.
Renamed to Tolerate any taints.
jsafrane
changed the title
|
@jsafrane: This pull request references Bugzilla bug 1863055, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
13 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
15 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jsafrane: All pull requests linked via external trackers have merged: openshift/aws-ebs-csi-driver-operator#71. Bugzilla bug 1863055 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Any node should be able to use PVCs. We don't know in advance what taints will be used in the cluster.
@openshift/storage