Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19248: Adjust OpenShift AI resources #2582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhernand
Copy link
Contributor

This patch adjust the resources needed to run the OpenShift AI operator. The previous values were too high, in particular the default resources for master nodes are enough, so there is no need to change them.

Note that in order to calculate these resources correctly it is also necessary to apply #2580.

Related: https://issues.redhat.com/browse/MGMT-19248
Related: https://issues.redhat.com/browse/MGMT-19056

This patch adjust the resources needed to run the _OpenShift AI_
operator. The previous values were too high, in particular the default
resources for master nodes are enough, so there is no need to change
them.

Related: https://issues.redhat.com/browse/MGMT-19248
Related: https://issues.redhat.com/browse/MGMT-19056
Signed-off-by: Juan Hernandez <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2024

@jhernand: This pull request references MGMT-19248 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This patch adjust the resources needed to run the OpenShift AI operator. The previous values were too high, in particular the default resources for master nodes are enough, so there is no need to change them.

Note that in order to calculate these resources correctly it is also necessary to apply #2580.

Related: https://issues.redhat.com/browse/MGMT-19248
Related: https://issues.redhat.com/browse/MGMT-19056

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from eliorerz and eranco74 November 28, 2024 22:10
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 28, 2024
Copy link

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhernand
Once this PR has been reviewed and has the lgtm label, please assign eliorerz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 28, 2024

@jhernand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node dd854ce link false /test e2e-metal-assisted-kube-api-late-binding-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eifrach
Copy link
Contributor

eifrach commented Dec 15, 2024

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

Copy link

openshift-ci bot commented Dec 15, 2024

@eifrach: Overrode contexts on behalf of eifrach: ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

In response to this:

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eifrach
Copy link
Contributor

eifrach commented Dec 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants