Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-ocm-2.4] Bug 2113981: Stop reconcile loop after changing CR inside BMAC #4227

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #4212

/assign mkowalski

This PR fixes the issue where returning `reconcileComplete{dirty: true}`
does not stop the reconciliation loop what leads to unexpected races and
objects being modified multiple times.

Cherry-picks: openshift#4201
Closes: Bug-2112817
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

@openshift-cherrypick-robot: Bugzilla bug 2112817 has been cloned as Bugzilla bug 2113981. Retitling PR to link against new bug.
/retitle [release-ocm-2.4] Bug 2113981: Stop reconcile loop after changing CR inside BMAC

In response to this:

[release-ocm-2.4] Bug 2112817: Stop reconcile loop after changing CR inside BMAC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-ocm-2.4] Bug 2112817: Stop reconcile loop after changing CR inside BMAC [release-ocm-2.4] Bug 2113981: Stop reconcile loop after changing CR inside BMAC Aug 2, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2113981, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (rhacm-2.4.2) matches configured target release for branch (rhacm-2.4.2)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2112817 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2112817 targets the "rhacm-2.5" release, which is one of the valid target releases: rhacm-2.5
  • bug has dependents

Requesting review from QA contact:
/cc @chadcrum

In response to this:

[release-ocm-2.4] Bug 2113981: Stop reconcile loop after changing CR inside BMAC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 2, 2022
@mkowalski
Copy link
Contributor

/approve
/cc @flaper87

@openshift-ci openshift-ci bot requested a review from flaper87 August 2, 2022 13:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, mkowalski, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 0808954 into openshift:release-ocm-2.4 Aug 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2113981 has been moved to the MODIFIED state.

In response to this:

[release-ocm-2.4] Bug 2113981: Stop reconcile loop after changing CR inside BMAC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants